[12_6_X] TriggerObjectTableProducer configuration and bug fixes

[vlimant]

PR description:

this is a back port of #40145, as most changes there are actually relevant for a 12.6 nano

PR validation:

all done in #40145

[cmsbuild]

A new Pull Request was created by @vlimant (vlimant) for CMSSW_12_6_X.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[vlimant]

enable nano

[vlimant]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-781a07/29323/summary.html
COMMIT: b753024
CMSSW: CMSSW_12_6_X_2022-11-29-1100/el8_amd64_gcc10
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40173/29323/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3416693
• DQMHistoTests: Total failures: 43
• DQMHistoTests: Total nulls: 53
• DQMHistoTests: Total successes: 3416575
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 132 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 14933
• DQMHistoTests: Total failures: 240
• DQMHistoTests: Total nulls: 98
• DQMHistoTests: Total successes: 14595
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 31 log files, 0 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.213	2.212	0.000 ( +0.0% )	9.17	9.16	+0.1%	1.518	1.564
2500.311	2.334	2.333	0.001 ( +0.0% )	8.78	8.72	+0.7%	1.888	1.933
2500.312	2.288	2.287	0.001 ( +0.0% )	8.80	8.91	-1.3%	1.900	1.925
2500.33	1.103	1.103	-0.000 ( -0.0% )	21.03	21.06	-0.2%	1.677	1.679
2500.331	1.403	1.402	0.000 ( +0.0% )	15.56	15.41	+1.0%	1.837	1.837
2500.332	1.336	1.335	0.001 ( +0.0% )	17.26	17.23	+0.1%	1.785	1.781
2500.4	2.109	2.107	0.001 ( +0.1% )	9.78	9.65	+1.3%	1.418	1.466
2500.401	2.136	2.135	0.000 ( +0.0% )	9.76	9.78	-0.2%	1.239	1.279
2500.5	0.301	0.301	0.000 ( +0.0% )	49.30	50.51	-2.4%	1.155	1.205
2500.501	0.301	0.301	0.000 ( +0.0% )	48.75	50.30	-3.1%	1.177	1.231
2500.51	1.075	1.074	0.000 ( +0.0% )	27.87	28.15	-1.0%	1.416	1.463
2500.511	1.107	1.107	0.000 ( +0.0% )	26.71	27.32	-2.3%	1.453	1.496
2500.6	1.413	1.413	0.000 ( +0.0% )	22.78	23.31	-2.3%	1.129	1.174
2500.601	1.445	1.444	0.001 ( +0.1% )	22.57	23.20	-2.7%	1.165	1.211

[vlimant]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

Sorry, I think I'm losing track here. Didn't we decide NOT to have a remini / renano in 12_6?

[vlimant]

we would still want this, in particular the bug fix part on matching to be in 12.6 to make it "usable for something"

[perrotta]

I imagine that the much larger number of TriggerObject selected enters the "bug fixes" part of this PR:

Can you please confirm @vlimant ?

[vlimant]

yes, getting more photon trigger objects is what we want to fix here (among other things)

[perrotta]

+1