Adding "hcal2" DQM to "rerecoCommon" in autoDQM.py

[abdoulline]

PR description:

Actual "rerecoCommon" sequence used in the data re-reco RelVals, for instance in the most recent "CMSSW_12_4_11_rerecoGTValidation" campaign
https://cms-talk.web.cern.ch/t/new-validation-campaign-cmssw-12-4-11-rerecogtvalidation-added/17645
-> RelMon
https://cms-pdmv.cern.ch/relmon/?q=CMSSW_12_4_11_PromptGTvsCMSSW_12_4_11_ReRecoGT

doesn't contain the most informative HCAL folders (HcalRecHitsD and CaloTowerdD) produced by "hcal2" DQM sequence.
This small update fixes the omission, as was discussed a ~week ago with the members of
cms-ppd-pdmv-dev
cms-PPD-conveners-DQM-DC

PR validation:

runTheMatrix.py -l limited

If this PR is a backport

it's not.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40172/33186

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

• DQMOffline/Configuration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[abdoulline]

I suppose it needs to be backported to 12_6_X... Just in case re-reco RelVals would be produced with it.

[rvenditti]

Hi Salavat, can you please add hcal2 also here: https://github.com/cms-sw/cmssw/blob/master/DQMOffline/Configuration/python/autoDQM.py#L183 ? otherwise i think that the harvesting step will not be enabled for this sequence. Thanks.

[abdoulline]

@rvenditti sorry for this omission 😕
now fixed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40172/33244

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #40172 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[rvenditti]

please test

[abdoulline]

Hm...m in my test (runTheMatrix.py -l limited) only several STEP1 failed due to EOS files unavailability...

May be I'm missing something (not having global-enough view of the consequences) and my rather simple-minded/seems-to-be-trivial modification may really cause some issues?
Apparently an insight of an expert is needed...

[perrotta]

please abort

[perrotta]

CMSSW_13_0_X_2022-11-30-2300 was broken
Let relaunch the tests now that the fixed CMSSW_13_0_X_2022-12-01-1100 is available

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a08062/29397/summary.html
COMMIT: ca5af44
CMSSW: CMSSW_13_0_X_2022-12-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40172/29397/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3421159
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3421137
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 158 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

type hcal

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1