-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.6.X] Fix warning message about PixelCPEFast
in TkTransientTrackingRecHitBuilderESProducer
#40171
[12.6.X] Fix warning message about PixelCPEFast
in TkTransientTrackingRecHitBuilderESProducer
#40171
Conversation
…nsientTrackingRecHitBuilderESProducer
type tracking, bug-fix |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_6_X. It involves the following packages:
@malbouis, @yuanchao, @ChrisMisan, @clacaputo, @cmsbuild, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d4d8c/29319/summary.html Comparison SummarySummary:
|
+alca |
urgent
|
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #40170
PR description:
This PR is a follow-up to #40003, which added the
TransientTrackingRechitBuilder
flavour forPixelCPEFast
.In that PR a new warning was emitted from
TkTransientTrackingRecHitBuilderESProducer
in order to warn the user that track angles will not be used, but since that was implemented in the constructor or the class, the message ended up being emitted every time theTransientTrackingRecHitBuilder_cfi
was loaded, leading to the misleading message thatPixelCPEFast
was used in the track fit, even when in fact it was not (logs from recent IB relvals show that the message is present in each one of them, see e.g. wf 1.0 or wf 250408.0 ).This PR fixes the problem by moving the
LogWarning
from the class constructor to theproduce
method, such that it is emitted only if the ES products are actually consumed by the downstream modules.I profit of this PR (in commit 6bcc614) to automatically supply a service needed in case of the
PixelCPEFast
choice in tracker alignment common refitting sequence.PR validation:
Tested with this branch that the spurious messages in relvals are removed.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #40170.