Add missing dependence on DataFormats/MuonReco to RecoLocalMuon/GEMCSCSegment/test/BuildFile.xml

[makortel]

PR description:

UBSAN fails to build because of

/pool/condor/dir_25578/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/c++ -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -fno-omit-frame-pointer -fsanitize=undefined -fsanitize=builtin -fsanitize=pointer-overflow -g -shared -Wl,-E -Wl,-z,defs tmp/el8_amd64_gcc11/src/RecoLocalMuon/GEMCSCSegment/test/GEMCSCCoincidenceRateAnalyzer/GEMCSCCoincidenceRateAnalyzer.cc.o -o tmp/el8_amd64_gcc11/src/RecoLocalMuon/GEMCSCSegment/test/GEMCSCCoincidenceRateAnalyzer/libGEMCSCCoincidenceRateAnalyzer.so -Wl,-E -Wl,--hash-style=gnu -L/pool/condor/dir_25578/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/1b2eaa275701962dee4e708dbb2a0228/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_0_UBSAN_X_2022-11-28-1100/biglib/el8_amd64_gcc11 -L/pool/condor/dir_25578/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/1b2eaa275701962dee4e708dbb2a0228/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_0_UBSAN_X_2022-11-28-1100/lib/el8_amd64_gcc11 -L/pool/condor/dir_25578/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/1b2eaa275701962dee4e708dbb2a0228/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_0_UBSAN_X_2022-11-28-1100/external/el8_amd64_gcc11/lib -lDataFormatsGEMRecHit -lDataFormatsCSCRecHit -lDataFormatsTrackingRecHit -lGeometryCSCGeometry -lGeometryGEMGeometry -lGeometryCommonTopologies -lCondFormatsAlignment -lDataFormatsGeometryCommonDetAlgo -lGeometryRecords -lCommonToolsUtilAlgos -lCondFormatsAlignmentRecord -lDataFormatsGeometrySurface -lSimDataFormatsTrackingHit -lCommonToolsUtils -lDataFormatsCLHEP -lDataFormatsEcalDetId -lDataFormatsGeometryVector -lDataFormatsL1GlobalTrigger -lDataFormatsMuonDetId -lFWCoreFramework -lSimDataFormatsTrack -lDataFormatsDetId -lDataFormatsL1GlobalMuonTrigger -lDataFormatsMath -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCorePluginManager -lFWCoreReflection -lCondFormatsSerialization -lFWCoreConcurrency -lFWCoreUtilities -lFWCoreVersion -lSimDataFormatsEncodedEventId -lTreePlayer -lGraf3d -lPostscript -lGpad -lGraf -lPhysics -lHist -lMatrix -lGenVector -lMathMore -lTree -lNet -lThread -lMathCore -lRIO -lboost_regex -lboost_serialization -lCore -lboost_thread -lboost_date_time -lCLHEP -lpcre -lbz2 -lgsl -luuid -ltbb -llzma -lz -lfmt -lcms-md5 -lopenblas -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2
  /pool/condor/dir_25578/jenkins/workspace/build-any-ib/w/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: tmp/el8_amd64_gcc11/src/RecoLocalMuon/GEMCSCSegment/test/GEMCSCCoincidenceRateAnalyzer/GEMCSCCoincidenceRateAnalyzer.cc.o:(.data.rel+0x4018): undefined reference to `typeinfo for reco::Muon'
 collect2: error: ld returned 1 exit status

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc11/CMSSW_13_0_UBSAN_X_2022-11-28-1100/RecoLocalMuon/GEMCSCSegment

The dependence on DataFormats/MuonReco seems to have been added in #39441. This PR adds the dependence explicitly. Since #39441 was merged in 12_6_X, I based this PR on the IB tag that is common between 12_6_X and 13_0_X so it can be trivially backported to 12_6_X.

PR validation:

None

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40166/33175

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• RecoLocalMuon/GEMCSCSegment (upgrade, reconstruction)

@cmsbuild, @AdrianoDee, @srimanob, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@bellan, @watson-ij, @missirol, @jhgoh, @trtomei, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test for CMSSW_13_0_UBSAN_X

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eca3dc/29310/summary.html
COMMIT: c8c541c
CMSSW: CMSSW_13_0_UBSAN_X_2022-11-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40166/29310/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 10042.010042.0_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step1_ZMM_13+2017+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

[makortel]

Compilation succeeded, which is sufficient for the UBSAN test

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eca3dc/29312/summary.html
COMMIT: c8c541c
CMSSW: CMSSW_13_0_X_2022-11-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40166/29312/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3421159
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3421134
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

Ping @cms-sw/reconstruction-l2 @cms-sw/upgrade-l2 (this PR is really simple)

[mandrenguyen]

+reconstruction

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1