Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL: Remove the MIP fine grain bit logic from the HCAL endcap #40165

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

Michael-Krohn
Copy link
Contributor

PR description:

This PR removes the functionality of the fine grain bits being set in the HCAL endcap according to MIP thresholds. This logic is not in the firmware on detector, so this PR causes the software to match the firmware on-detector. This discrepancy between off-detector software and the on-detector firmware was discovered during an HCAL conditions update last week and a detailed discussion about it can be found in the L1 JIRA ticket

PR validation:

A basic technical test was performed: runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40165/33174

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Michael-Krohn for master.

It involves the following packages:

  • CalibCalorimetry/HcalTPGAlgos (l1, alca)

@malbouis, @yuanchao, @epalencia, @cmsbuild, @rekovic, @saumyaphor4252, @tvami, @ChrisMisan, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @abdoulline, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Nov 28, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bdacb/29308/summary.html
COMMIT: 96f0ace
CMSSW: CMSSW_13_0_X_2022-11-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40165/29308/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@abdoulline
Copy link

CalibCalorimetry/HcalTPGAlgos/src/HcaluLUTTPGCoder.cc:410:37: warning: unused variable 'channelParameters'

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40165/33187

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40165 was updated. @malbouis, @yuanchao, @epalencia, @cmsbuild, @rekovic, @saumyaphor4252, @tvami, @ChrisMisan, @cecilecaillol, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Nov 29, 2022

@Michael-Krohn please squash the commits (now you have 2 commits changing 1 file)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40165/33194

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40165 was updated. @malbouis, @yuanchao, @epalencia, @cmsbuild, @rekovic, @saumyaphor4252, @tvami, @ChrisMisan, @cecilecaillol, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Nov 29, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bdacb/29337/summary.html
COMMIT: b2d8a1a
CMSSW: CMSSW_13_0_X_2022-11-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40165/29337/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421159
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421125
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Nov 30, 2022

I see changes in
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_0_X_2022-11-29-1100+3bdacb/54401/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3/Hcal_TPTask.html

is this expected? Given that you are modifying the HcalTPGAlgos I would think yes, not the question is: is it changing to the right direction?

@Michael-Krohn
Copy link
Contributor Author

Hi @tvami, yes I believe these are the expected changes. This PR removes the logic from setting bit 4 of the fine grain bits. And now it shows that this bit is always set to 0, which is what we expect, and it was set to 1 at times with the previous logic. Also, you can see that this change is always occurring in the endcap, which is also expected

@tvami
Copy link
Contributor

tvami commented Dec 1, 2022

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Dec 2, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants