-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCAL: Remove the MIP fine grain bit logic from the HCAL endcap #40165
HCAL: Remove the MIP fine grain bit logic from the HCAL endcap #40165
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40165/33174
|
A new Pull Request was created by @Michael-Krohn for master. It involves the following packages:
@malbouis, @yuanchao, @epalencia, @cmsbuild, @rekovic, @saumyaphor4252, @tvami, @ChrisMisan, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
-1 Failed Tests: Build ClangBuild BuildI found compilation warning when building: See details on the summary page. Clang BuildI found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
CalibCalorimetry/HcalTPGAlgos/src/HcaluLUTTPGCoder.cc:410:37: warning: unused variable 'channelParameters' |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40165/33187
|
Pull request #40165 was updated. @malbouis, @yuanchao, @epalencia, @cmsbuild, @rekovic, @saumyaphor4252, @tvami, @ChrisMisan, @cecilecaillol, @francescobrivio can you please check and sign again. |
@Michael-Krohn please squash the commits (now you have 2 commits changing 1 file) |
Remove unused variable
8263520
to
b2d8a1a
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40165/33194
|
Pull request #40165 was updated. @malbouis, @yuanchao, @epalencia, @cmsbuild, @rekovic, @saumyaphor4252, @tvami, @ChrisMisan, @cecilecaillol, @francescobrivio can you please check and sign again. |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bdacb/29337/summary.html Comparison SummarySummary:
|
is this expected? Given that you are modifying the |
Hi @tvami, yes I believe these are the expected changes. This PR removes the logic from setting bit 4 of the fine grain bits. And now it shows that this bit is always set to 0, which is what we expect, and it was set to 1 at times with the previous logic. Also, you can see that this change is always occurring in the endcap, which is also expected |
+alca
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR removes the functionality of the fine grain bits being set in the HCAL endcap according to MIP thresholds. This logic is not in the firmware on detector, so this PR causes the software to match the firmware on-detector. This discrepancy between off-detector software and the on-detector firmware was discovered during an HCAL conditions update last week and a detailed discussion about it can be found in the L1 JIRA ticket
PR validation:
A basic technical test was performed: runTheMatrix.py -l limited -i all --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport