Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove left over uGMT ZS configuration [12_5_X] #40164

Merged

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Nov 28, 2022

PR description:

This removes some left over calls to modules that were removed in #38115.

cc @pmandrik and @vukasinmilosevic

Backport of #40107.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2022

A new Pull Request was created by @dinyar (Dinyar Rabady) for CMSSW_12_5_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

type l1t

@cmsbuild cmsbuild added the l1t label Nov 28, 2022
@emanueleusai
Copy link
Member

backport of #40107

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ea539/29301/summary.html
COMMIT: d49bba6
CMSSW: CMSSW_12_5_X_2022-11-28-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40164/29301/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3722333
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3722297
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

please test

  • retesting relval timed out

@perrotta
Copy link
Contributor

+1

  • Merging just to have the offline release aligned with what deployed in the online DQM release at P5 at the end of the data taking: there will be no real usage for this PR in a possible future release in this cycle.

@perrotta
Copy link
Contributor

merge

  • Tests were already succesfull here in 12_5_X, besides the usual timeouf of the RelVal input tests
  • DQM already signed bot the master and the 12_4_X version of this PR, both identical to this one in 12_5_X
  • Let merge also here then, to clean up the queue a bit

@cmsbuild cmsbuild merged commit 4c9240b into cms-sw:CMSSW_12_5_X Nov 29, 2022
@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_0_X is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants