-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx330 Transfer most of the HGCal TB related geometry file to the new branch Geometry/HGCalTBCommonData #40122
Conversation
… Geometry/HGCalTBCommonData
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40122/33115
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
The following packages do not have a category, yet: Geometry/HGCalTBCommonData @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
@smuzaffar Could you please add this package in the list |
Pull request #40122 was updated. @civanch, @Dr15Jones, @makortel, @ianna, @mdhildreth, @bsunanda can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b60fa3/29226/summary.html Comparison SummarySummary:
|
+geometry |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Transfer most of the HGCal test-beam related geometry files to anew project area Geometry/HGCalTBCommonData. Once this PR is merged and this project area is declared as a part of CMSSW, the corresponding files in Geometry/HGCalCommonData will be deleted
PR validation:
A thorough test will be done once the corresponding files in SimG4CMS are updated
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special