-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HI rawDataInputTag for beamhlt DQM client #40109
Conversation
type bug-fix |
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40109/33094
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@emanueleusai, @ahmad3213, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
DQM/Integration/python/clients/beamhlt_dqm_sourceclient-live_cfg.py
Outdated
Show resolved
Hide resolved
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d92434/29123/summary.html
Comparison SummarySummary:
|
hold
|
Pull request has been put on hold by @mmusich |
cea5e6f
to
0ce5001
Compare
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40109/33108
|
Pull request #40109 was updated. @emanueleusai, @ahmad3213, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again. |
unhold
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d92434/29149/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR fixes the crash observed during HeavyIon data-taking in the online DQM client
beamhlt
:The issue arises from the fact that the
streamDQMOnlineBeamspot
does not containrawDataRepacker
, but:This PR adds the correct
rawDataInputTag
for the HI case.PR validation:
None, 12_5_X backport to be tested online in P5
Backport:
Not a backport, backport to 12_5_X available in #40108