-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
short names for matrix workflows #40106
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40106/33090
|
A new Pull Request was created by @vlimant (vlimant) for master. It involves the following packages:
@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40106/33123
|
Pull request #40106 was updated. @bbilin, @srimanob, @sunilUIET, @kskovpen, @AdrianoDee can you please check and sign again. |
-1 Failed Tests: RelVals RelVals-INPUT AddOn RelVals
Expand to see more relval errors ...RelVals-INPUT
AddOn Tests
Expand to see more addon errors ... |
please test with cms-sw/cms-bot#1897 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-353010/29393/summary.html Comparison SummarySummary:
|
+upgrade |
@cms-sw/pdmv-l2 please resign |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@vlimant , looks like after this change Relvals logs from IB page are not accessible. The IB page reads runall-report-step123-.log files to get the workflows names and this file still contains the long names [a]. Can you please update https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/WorkFlowRunner.py#L210 to also use short names?
|
I had kept the step list in the final report so that one could see what step was failing directly. I overlooked that something was grabbing the directory names from that file (and honestly I was expecting that some script would). |
IBs page uses |
I mean, can the parsing be done and mapping to the actual directory done by wf id, instead of removing the step list in #40235 |
yes can be done but I would suggest to keep the |
PR description:
while going through cms-sw/cms-bot#1872 we discussed the painful long workflow names and subsequent long directory names.
this PR uses the mostly unused feature of defining a nickname for a workflow using the first string
wf[num] = ['anickname', ['step1name', ...] ]
the visual of
--show
and therunall-report-step123-.log
are mostly unchangedbut I'd like to check on opinions about this, and the interaction with cms-bot
PR validation:
configuring a couple of workflows with
runTheMatrix.py -l limited -j 0
went smoothly.