Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt protection against zero weights or pt for SV producer #40093

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Adapt protection against zero weights or pt for SV producer #40093

merged 3 commits into from
Nov 22, 2022

Conversation

AnnikaStein
Copy link
Contributor

@AnnikaStein AnnikaStein commented Nov 16, 2022

PR description:

This PR applies the same protective measures introduced in #40081 for another producer in the RecoBTag/SecondaryVertex package. While we have not seen a precedent case that yields the abort signal reported in #40032 coming from this particular producer (TemplatedSecondaryVertexProducer.cc), the logic is essentially same, so we think we should include the fixes here for safety purposes as well.

PR validation:

Tests have been performed for CMSSW_12_6_0_pre4 in the following way (https://cms-sw.github.io/PRWorkflow.html):

cd src
scram b distclean 
git cms-checkdeps -a -A
scram b -j 8
scram b runtests
runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Planning backports to 12_4_X and 12_5_X, similar to what was discussed in related discussion in #40032

@cmsbuild
Copy link
Contributor

@AnnikaStein, CMSSW_12_6_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40093/33072

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40093/33073

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AnnikaStein (Annika Stein) for master.

It involves the following packages:

  • RecoBTag/SecondaryVertex (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @JyothsnaKomaragiri, @AnnikaStein, @missirol, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@AnnikaStein AnnikaStein marked this pull request as ready for review November 16, 2022 23:39
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40093/33076

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40093 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

@mandrenguyen
Copy link
Contributor

please test

@mandrenguyen
Copy link
Contributor

please abort

@mandrenguyen
Copy link
Contributor

please test

@mandrenguyen
Copy link
Contributor

please abort

@mandrenguyen
Copy link
Contributor

please test
in the ORP i just heard that tests should work again now

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c391e8/29189/summary.html
COMMIT: fa73813
CMSSW: CMSSW_12_6_X_2022-11-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40093/29189/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417239
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3417211
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 97b79e2 into cms-sw:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants