-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt protection against zero weights or pt for SV producer #40093
Adapt protection against zero weights or pt for SV producer #40093
Conversation
@AnnikaStein, CMSSW_12_6_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40093/33072
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40093/33073
|
A new Pull Request was created by @AnnikaStein (Annika Stein) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40093/33076
|
Pull request #40093 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again. |
please test |
please abort |
please test |
please abort |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c391e8/29189/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR applies the same protective measures introduced in #40081 for another producer in the
RecoBTag/SecondaryVertex
package. While we have not seen a precedent case that yields the abort signal reported in #40032 coming from this particular producer (TemplatedSecondaryVertexProducer.cc
), the logic is essentially same, so we think we should include the fixes here for safety purposes as well.PR validation:
Tests have been performed for CMSSW_12_6_0_pre4 in the following way (https://cms-sw.github.io/PRWorkflow.html):
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Planning backports to 12_4_X and 12_5_X, similar to what was discussed in related discussion in #40032