-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect against particles with zero weight and pt being given to njettiness [12_5_X] #40092
Protect against particles with zero weight and pt being given to njettiness [12_5_X] #40092
Conversation
A new Pull Request was created by @laurenhay (Lauren Hay) for CMSSW_12_5_X. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Backport of #40081 |
urgent |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bee59e/29087/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 Backport of PR that fixes prompt reco crash. |
PR description:
As discussed in issue #40032 , BoostedDoubleSVProducer caused an abort signal in a reco job.
We found that there were unrealistic kinematic values in fjParticles being input to njettiness and are protecting against it by requiring a nonzero weight and pt > epsilon.
PR validation:
Verified that this fix solves the issues in CMSSW_12_4_10_patch3 and ran usual code check and that basic runTheMatrix workflows run in 12_5_2_patch1
@rappoccio
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Original PR: #40081
First bp: #40088
Backport is needed so that future reco jobs run without being stopped by this issue