[125X] Improve unprotected areas of GSF code to avoid segfault

[swagata87]

Backport of #40084

Addresses #39987 (comment)

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_12_5_X.

It involves the following packages:

• TrackingTools/GsfTracking (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @bellan, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @ebrondol, @lecriste, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Improve unprotected areas of GSF code to avoid segfault #40084

[swagata87]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec1bb6/29047/summary.html
COMMIT: 3737b55
CMSSW: CMSSW_12_5_X_2022-11-16-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40086/29047/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3734871
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3734841
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 216 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[swagata87]

@cmsbuild please test

last time it failed as tests timed out..

[perrotta]

+1

• This is a verbatim backport of Improve unprotected areas of GSF code to avoid segfault #40084, which was already signed by @cms-sw/reconstruction-l2
• Let have it merged, assuming that reco would also sign it, so that it can enter in the 1100 IBs

[perrotta]

merge

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_6_X is complete.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec1bb6/29070/summary.html
COMMIT: 3737b55
CMSSW: CMSSW_12_5_X_2022-11-16-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40086/29070/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3734871
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3734835
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 216 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found