Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[125X] Remove tracking MVA tags from Run-3 MC and data GTs #40078

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Nov 15, 2022

PR description:

See #40010
and #40011

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #40010 and #40011

@tvami
Copy link
Contributor Author

tvami commented Nov 15, 2022

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2022

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_5_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Nov 15, 2022

backport of #40010

@tvami
Copy link
Contributor Author

tvami commented Nov 15, 2022

backport of #40011

@tvami
Copy link
Contributor Author

tvami commented Nov 15, 2022

@cmsbuild , please test

@tvami tvami changed the title Remove tracking mv atags 125 x [125X] Remove tracking MVA tags from Run-3 MC and data GTs Nov 15, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-575bbb/29015/summary.html
COMMIT: 0d38af0
CMSSW: CMSSW_12_5_X_2022-11-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40078/29015/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-575bbb/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-575bbb/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4193005
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 4192969
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 54 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 235 log files, 49 edm output root files, 55 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Nov 16, 2022

+alca

  • changes in MsgLogger only, master PR of these are fine in the IBs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@cmsbuild cmsbuild merged commit bd89710 into cms-sw:CMSSW_12_5_X Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants