Fix the ThroughputService and FastTimerService DQM folders

[fwyzard]

PR description:

Include the information about whether Simultaneous Multi Threading (SMT) is enabled or disabled after the processor model name.

Fix the DQM folder used by the ThroughputService to take into account the processor model name (and the SMT status) if the corresponding flag is enabled.

PR validation:

The processor model name and the SMT status not appear correctly in the DQM folder names for the FastTimerService and ThroughputService:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to CMSSW 12.4.x and 12.5.x for data taking.

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40062/33040

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• HLTrigger/Timer (hlt)

@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

@smuzaffar somethin's weird is going on with the tests ?
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/28998/console says "success", but the bot still list the test as "Pending" ?

[cmsbuild]

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5190be/28998/summary.html
COMMIT: c31ecff
CMSSW: CMSSW_12_6_X_2022-11-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40062/28998/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

• hlt_mc_PRef

----- Begin Fatal Exception 15-Nov-2022 15:14:01 CET-----------------------
An exception of category 'BadMonitorElementPathName' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Exception Message:
 Monitor element path name: 'roughput/Running on Intel(R) Xeon(R) CPU E5-2683 v4 @ 2.10GHz with SMT disabled with 4 streams on 4 threads/throughput_sourced' uses unacceptable characters.
 Acceptable characters are: /ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-+=_()# 
----- End Fatal Exception -------------------------------------------------

• hlt_mc_PRef

----- Begin Fatal Exception 15-Nov-2022 15:14:01 CET-----------------------
An exception of category 'BadMonitorElementPathName' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Exception Message:
 Monitor element path name: 'roughput/Running on Intel(R) Xeon(R) CPU E5-2683 v4 @ 2.10GHz with SMT disabled with 4 streams on 4 threads/throughput_sourced' uses unacceptable characters.
 Acceptable characters are: /ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-+=_()# 
----- End Fatal Exception -------------------------------------------------

• hlt_mc_PRef

----- Begin Fatal Exception 15-Nov-2022 15:14:01 CET-----------------------
An exception of category 'BadMonitorElementPathName' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Exception Message:
 Monitor element path name: 'roughput/Running on Intel(R) Xeon(R) CPU E5-2683 v4 @ 2.10GHz with SMT disabled with 4 streams on 4 threads/throughput_sourced' uses unacceptable characters.
 Acceptable characters are: /ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-+=_()# 
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

• hlt_mc_PRef
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_mc_PRef

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417074
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3417037
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40062/33056

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #40062 was updated. @Martin-Grunewald, @missirol can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5190be/29019/summary.html
COMMIT: 27815f8
CMSSW: CMSSW_12_6_X_2022-11-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40062/29019/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417074
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3417046
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1