Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_5_X (1/N): HLT HIon V1.0 of 2022 #40047

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

missirol
Copy link
Contributor

backport of #40046

PR description:

Development of HLT menus for CMSSW_12_5_X.

This version of the HIon HLT menu corresponds to "HLT HIon V1.0" for the 2022 HIon (test) run.

All development menus (e.g. GRun) and frozen menus are migrated to the latest ConfDB template for the 12_5_X release cycle. In particular, the frozen HLT menu ("HLT V1.4") of this release cycle is updated to run in 12_5_X without extra customisations (this is purely a technical change, no physics changes expected).

This PR includes the integration of the following JIRA tickets.

  • CMSHLT-2532: [HIon] updated HIDQMEventDisplay stream (added HIMinBias trigger with smartPS of 2000)
  • CMSHLT-2536: [HIon] switched to rawDataRepacker in EventContent of HIDQMEventDisplay
  • CMSHLT-2541: [EXO] set PS=0 for HLT_HT200_L1SingleLLPJet_DisplacedDijet30_Inclusive1PtrkShortSig5_v
  • CMSHLT-2542: [TSG] set PS=1 for HLT_EphemeralZeroBias_v
  • CMSHLT-2546: [BPH] set PS=20 for HLT_DoubleMu4_3_Jpsi_v
  • CMSHLT-2547: [TSG,TRK] increased PSs of HLT_HT300_Beamspot_v trigger
  • CMSHLT-2548: [EXO,MUO] set PS=1 for HLT_Mu50_L1SingleMuShower_v trigger
  • CMSHLT-2550: [TSG] changed default PS column to "2p0E34"
  • CMSHLT-2553: [BPH] added dielectron-parking triggers with trkHits10 cut
  • CMSHLT-2556: [HIon] added HLT_HIRandom_v to HITestRaw and HITestRawPrime PDs
  • CMSHLT-2559: [TRK] updated EventContent of HIDQMOnlineBeamspot stream
  • CMSHLT-2560: [HIon] added FED 1022 to rawPrimeDataRepacker
  • CMSHLT-2563: [HIon] fixed offset of HIMinBias prescaler and smartPS of HIZeroBias in HIExpressPhysics PD
  • CMSHLT-2565: [LUM,HIon] added AlCaPCC triggers and streams to HIon menu (combined table unchanged)
  • CMSHLT-2566: [HIon] added HIUPC triggers to HITestRawPrime PD

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#40046

Development of HLT menus for 2022 data-taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 10, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_5_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d1795/28962/summary.html
COMMIT: 584c95b
CMSSW: CMSSW_12_5_X_2022-11-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40047/28962/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3734649
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3734625
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.093 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.013 KiB HLT/Filters
  • DQMHistoSizes: changed ( 7.3,... ): 0.001 KiB HLT/Filters
  • Checked 216 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

  • a few differences in the outputs of PR tests are due to the updated names of the HLT menus (e.g. "12_4" -> "12_5")
  • no physics-related differences as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor Author

@cms-sw/orp-l2 , kind ping about this backport PR.

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 94b052b into cms-sw:CMSSW_12_5_X Nov 14, 2022
@missirol missirol deleted the HLTdevelopment125X branch November 15, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants