Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EDM inputs to HLT-Validation tests [5_3_X only] #40031

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Nov 9, 2022

PR description:

This PR is specific to the CMSSW_5_3_X release cycle.

Some of the HLT-Validation tests running in IBs started to fail due to the unavailability of EDM files used as input to these tests (see IB dashboard, and #40013).

This PR updates the path to these files, to use copies kept in the TSG area on EOS. which will now rely on the cms-bot cache (see discussion in #40013 and #40020, where the corresponding updates to cms-bot are also mentioned).

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_5_3_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • Utilities/ReleaseScripts (core)

@Martin-Grunewald, @Dr15Jones, @smuzaffar, @makortel, @cmsbuild, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Nov 9, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3600ef/28919/summary.html
COMMIT: a5d1af1
CMSSW: CMSSW_5_3_X_2022-11-06-0000/slc6_amd64_gcc472
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40031/28919/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 11 failed jobs
  • DQMHistoTests: Total files compared: 8
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -7 KiB( 7 files compared)
  • Checked 37 log files, 0 edm output root files, 8 DQM output files

@vlimant
Copy link
Contributor

vlimant commented Nov 21, 2022

please test

to check compilation of validation scripts from 1872

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3600ef/29165/summary.html
COMMIT: a5d1af1
CMSSW: CMSSW_5_3_X_2022-11-20-0000/slc6_amd64_gcc472
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40031/29165/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 11 failed jobs
  • DQMHistoTests: Total files compared: 8
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -7 KiB( 7 files compared)
  • Checked 37 log files, 0 edm output root files, 8 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #40031 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3600ef/29212/summary.html
COMMIT: 36e3e41
CMSSW: CMSSW_5_3_X_2022-11-20-0000/slc6_amd64_gcc472
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40031/29212/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 8
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -7 KiB( 7 files compared)
  • Checked 37 log files, 0 edm output root files, 8 DQM output files

@missirol
Copy link
Contributor Author

+hlt

This PR is part of #40013, although not strictly needed since the IB tests are already not failing (see item 2. of #40013 (comment)). I would still prefer to have this merged to be consistent across (active) release cycles.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5525137 into cms-sw:CMSSW_5_3_X Nov 24, 2022
@missirol missirol deleted the fixHLTValTests_53X branch November 24, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants