Fix rerecoCommon DQM sequence

[francescobrivio]

PR description:

It was noted in JIRA-PDMVRERECO-55 that the @rerecoCommon DQM sequence it's broken with error:

----- Begin Fatal Exception 31-Oct-2022 15:04:43 CET-----------------------
An exception of category 'HCALDQM' occurred while
   [0] Processing  Event run: 355680 lumi: 1 event: 583350 stream: 0
   [1] Running path 'dqmoffline_1_step'
   [2] Calling method for module TPTask/'tpTask'
Exception Message:
TPTask::Collection HcalTrigPrimDigiCollection isn't available: valHcalTriggerPrimitiveDigis 
----- End Fatal Exception -------------------------------------------------

This error was already observed last year in dmwm/T0#4619 (comment) and a fix was implemented by @jfernan2 in #35605.
However the fix was not propagated to the @rerecoCommon sequence, so this PR does that.

PR validation:

Running in CMSSW_12_4_10_patch3:

dasgoclient --limit 0 --query "file dataset=/ZeroBias/Run2022B-v1/RAW run in [355680]" >> ReReco-Run2022B-ZeroBias-30Oct22_pilot-00001_files.txt

cmsDriver.py RECO --conditions 124X_dataRun3_v10 --customise Configuration/DataProcessing/RecoTLR.customisePostEra_Run3,Configuration/DataProcessing/Utils.addMonitoring --datatier AOD,MINIAOD,DQMIO --era Run3 --eventcontent AOD,MINIAOD,DQM --filein "filelist:ReReco-Run2022B-ZeroBias-30Oct22_pilot-00001_files.txt" --fileout "file:ReReco-Run2022B-ZeroBias-30Oct22_pilot-00001.root" --nThreads 8 --number 10 --python_filename "ReReco-Run2022B-ZeroBias-30Oct22_pilot-00001_0_cfg.py" --scenario pp --step RAW2DIGI,L1Reco,RECO,PAT,DQM:@rerecoCommon --data

gives the crash.
While running with this PR on top of it, the driver runs to completion.

Backport:

Not a backport, but 12_4_X and 12_5_X backports will be provided soon.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39934/32866

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• DQMOffline/Configuration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

@cmsbuild please test

[francescobrivio]

@cms-sw/dqm-l2 please take a look at other sequences if they need updates or not.
Also, looking at the RunTheMatrix tests I don't see the rerecoCommon sequence used anywhere, not sure if I just missed it.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-724ead/28674/summary.html
COMMIT: 54d70d3
CMSSW: CMSSW_12_6_X_2022-10-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39934/28674/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3416356
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3416331
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-724ead/28698/summary.html
COMMIT: 54d70d3
CMSSW: CMSSW_12_6_X_2022-10-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39934/28698/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3416398
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3416364
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

type bug-fix

[rappoccio]

urgent

[mmusich]

ping @cms-sw/dqm-l2

[syuvivida]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1