Run3-hcx336 Backport #39920 to 12_5_X to protect against wrong ieta values which happens for wrong mixing of signal and PU SIM results

[bsunanda]

PR description:

Backport #39920 to CMSSW_12_5_X in order to protect against wrong ieta values which happens for wrong mixing of signal and PU SIM results

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport a fix given in the master branch in PR #39920

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_5_X.

It involves the following packages:

• CondFormats/GeometryObjects (db, alca)
• Geometry/HcalCommonData (geometry)

@malbouis, @civanch, @Dr15Jones, @makortel, @saumyaphor4252, @ianna, @mdhildreth, @cmsbuild, @bsunanda, @yuanchao, @ggovi, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @mmusich, @fabiocos, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Run3-hcx335 Add protection to eta values for phase2 scenario in HCAL geometry #39920

[cmsbuild]

Pull request #39921 was updated. @malbouis, @civanch, @Dr15Jones, @makortel, @saumyaphor4252, @ianna, @mdhildreth, @cmsbuild, @bsunanda, @yuanchao, @ggovi, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[civanch]

@bsunanda , please, add [12_5] in front of the title

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20acf2/28627/summary.html
COMMIT: cb68e2a
CMSSW: CMSSW_12_5_X_2022-10-28-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39921/28627/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3702776
• DQMHistoTests: Total failures: 156
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3702597
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[ChrisMisan]

please test

• Differences in wf 11634.7 were reported here spurious differences in outputs of Run-3 wfs *.7 #39803. Re-running tests.

[ChrisMisan]

@bsunanda please look at the comment #39921 (comment)

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20acf2/28631/summary.html
COMMIT: cb68e2a
CMSSW: CMSSW_12_5_X_2022-10-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39921/28631/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3702776
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3702740
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20acf2/28638/summary.html
COMMIT: cb68e2a
CMSSW: CMSSW_12_5_X_2022-10-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39921/28638/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3702776
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3702746
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #39921 was updated. @malbouis, @civanch, @Dr15Jones, @makortel, @saumyaphor4252, @ianna, @mdhildreth, @cmsbuild, @bsunanda, @yuanchao, @ggovi, @tvami, @ChrisMisan, @francescobrivio can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20acf2/28668/summary.html
COMMIT: 8cf6650
CMSSW: CMSSW_12_5_X_2022-10-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39921/28668/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3702776
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3702746
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[tvami]

+1

• changes in MsgLogger only
• test pass

[bsunanda]

+geometry

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• This PR will make the issue described in heap-buffer-overflow HcalDDDSimConstants::getPhiCons() #39480 more visible also in 12_5, as it is already the case in the master
• Affected workflows with wrong geom configs will crash also in 12_5 then. Once the fix is found, it will have to be backported also in 12_5_x