HCAL: Modifications to the HCAL trigger key generation scripts

[Michael-Krohn]

PR description:

This PR adds the feature to create plots comparing the HCAL effective pedestals before and after a condition change.

PR validation:

A basic technical test was performed: runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport. This PR updates the "service" scripts for LUTs and Trigger key generation, so the changes do not need to be backported to 12_4_X/12_5_X

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39918/32830

ERROR: Build errors found during clang-tidy run.

CaloOnlineTools/HcalOnlineDb/plugins/HcalLutAnalyzer.cc:250:3: error: expected expression [clang-diagnostic-error]
>>>>>>> 1e2a0a5ca7c (modify the HCAL trigger key generation scripts)
  ^
CaloOnlineTools/HcalOnlineDb/plugins/HcalLutAnalyzer.cc:250:5: error: expected expression [clang-diagnostic-error]
>>>>>>> 1e2a0a5ca7c (modify the HCAL trigger key generation scripts)
    ^
CaloOnlineTools/HcalOnlineDb/plugins/HcalLutAnalyzer.cc:250:7: error: expected expression [clang-diagnostic-error]
>>>>>>> 1e2a0a5ca7c (modify the HCAL trigger key generation scripts)
      ^
CaloOnlineTools/HcalOnlineDb/plugins/HcalLutAnalyzer.cc:250:12: error: invalid suffix 'a0a5ca7c' on floating constant [clang-diagnostic-error]
>>>>>>> 1e2a0a5ca7c (modify the HCAL trigger key generation scripts)
           ^
CaloOnlineTools/HcalOnlineDb/plugins/HcalLutAnalyzer.cc:250:22: error: use of undeclared identifier 'modify' [clang-diagnostic-error]
>>>>>>> 1e2a0a5ca7c (modify the HCAL trigger key generation scripts)
                     ^
Suppressed 1990 warnings (1989 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39918/32831

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Michael-Krohn for master.

It involves the following packages:

• CaloOnlineTools/HcalOnlineDb (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[tvami]

hi @Michael-Krohn after code-checks are fine, would you please squash the commits?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39918/32863

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #39918 was updated. @malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39918/32865

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #39918 was updated. @malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[cmsbuild]

Pull request #39918 was updated. @malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[tvami]

@Michael-Krohn now you need to rebase too. Also I think you didnt squash the commit, you just renamed it.

[Michael-Krohn]

Hi @tvami, yes I was struggling with squashing the commits, but I have finally succeeded

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39918/32869

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #39918 was updated. @malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b0344/28678/summary.html
COMMIT: 14da6dd
CMSSW: CMSSW_12_6_X_2022-10-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39918/28678/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3416356
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3416331
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tvami]

+db

• tests pass, no diffs besides MsgLogger

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1