Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use --hltProcess reHLT in Run-3 Data RelVals [12_5_X] #39899

Merged
merged 1 commit into from
Oct 31, 2022
Merged

use --hltProcess reHLT in Run-3 Data RelVals [12_5_X] #39899

merged 1 commit into from
Oct 31, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Oct 28, 2022 •
edited
Loading

backport of #39834

PR description:

From the description of #39834:

This PR is an attempt to solve #39714 by updating the Run-3 Data RelVal wfs to use the HLT results from the (re)HLT step of a given wf (process name = reHLT), rather than from the collections in wf's input files (process name = HLT). Minor renaming/refactoring of transient variables in relval_steps and relval_standard was done in the process.

Changes can be expected in the outputs of the affected workflows, as this changes which HLT results are used by their post-HLT steps (e.g. PAT and DQM).

To add --hltProcess reHLT to the post-HLT step of the Run-3 data RelVals, the following is done:

  • rename HLTDR3_2021 to HLTDR3_2022;
  • replace HLTRUN3 with HLTDR3_2022 (they are identical, making the first redundant);
  • create RECODR3_reHLT (= "RECODR3 + --hltProcess=reHLT");
  • replace RECODR3_2021 with RECODR3_reHLT;
  • rename RECONANORUN3 to RECONANORUN3_reHLT, and base it off of RECODR3_reHLT;
  • rename RECOCOSMRUN3 to RECOCOSMRUN3_reHLT.

This backport is not verbatim due to differences in relval_{steps,standard}.py across different release cycles.

PR validation:

runTheMatrix.py -l 139.001,140.001 passed.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#39834

Fix to Run-3 Data RelVal wfs involving HLT.

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Oct 28, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2022 •
edited
Loading

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_5_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

test parameters:

  • workflows = 139.001,139.002,139.003,139.004,140.001,140.002,140.104,140.105,140.106,140.107,140.109,140.110,140.111,140.112,140.113,140.114,140.115,140.116,140.117

@missirol
Copy link
Contributor Author

please test

@missirol missirol mentioned this pull request Oct 28, 2022
Closed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c58fe/28596/summary.html
COMMIT: b71f365
CMSSW: CMSSW_12_5_X_2022-10-28-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39899/28596/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.002, 140.001, 139.004, 139.003, 139.002, 139.001 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/139.002_RunZeroBias2021+RunZeroBias2021+HLTDR3_2022+RECODR3_reHLT_ZBOffline+HARVESTD2021ZB
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/139.003_RunHLTPhy2021+RunHLTPhy2021+HLTDR3_2022+RECODR3_reHLT_HLTPhysics_Offline+HARVESTD2021HLTPhy
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/139.004_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2022+RECODR3_reHLT_AlCaTkCosmics_Offline+HARVESTDR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.001_RunMinimumBias2022B+RunMinimumBias2022B+HLTDR3_2022+RECONANORUN3_reHLT+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.002_RunZeroBias2022B+RunZeroBias2022B+HLTDR3_2022+RECONANORUN3_reHLT+HARVESTRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.104_RunZeroBias2022B+RunZeroBias2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMZEROBIASRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.105_RunBTagMu2022B+RunBTagMu2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMBTAGMURUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.106_RunJetHT2022B+RunJetHT2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMJETMETRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.107_RunDisplacedJet2022B+RunDisplacedJet2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMDISPLACEDJETRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.109_RunEGamma2022B+RunEGamma2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMEGAMMARUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.111_RunDoubleMuon2022B+RunDoubleMuon2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMMUONRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.112_RunMuonEG2022B+RunMuonEG2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMMUONEGRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.113_RunNoBPTX2022B+RunNoBPTX2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMNOBPTXRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.114_RunHcalNZS2022B+RunHcalNZS2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMHCALNZSRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.115_RunHLTPhysics2022B+RunHLTPhysics2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMHLTPHYSICSRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.116_RunCommissioning2022B+RunCommissioning2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMCOMMISSIONINGRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.117_RunCosmics2022B+RunCosmics2022B+HLTDR3_2022+RECOCOSMRUN3_reHLT+SKIMCOSMICSRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c58fe/140.11_RunTau2022B+RunTau2022B+HLTDR3_2022+RECONANORUN3_reHLT+SKIMTAURUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 56
  • DQMHistoTests: Total histograms compared: 3663773
  • DQMHistoTests: Total failures: 1003
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3662747
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 46 edm output root files, 56 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@missirol could you please add a few lines in the PR description that can explain the difference between the PR merged in master, and the two backports in 12_4 and 12_5, and the differences betwee the two backports themselves?

@missirol
Copy link
Contributor Author

missirol commented Oct 31, 2022 •
edited
Loading

Description updated.

Indeed, the backports are not verbatim (and had to be done manually), because relval_{steps,standard}.py differ too much across the 3 release cycles.

The net result of these 3 PRs, though, is the same: add --hltProcess reHLT to the post-HLT step of the Run-3 data RelVals (whichever those are in a given release cycle).

Each of these 3 PRs was done as follows:

  • rename HLTDR3_2021 to HLTDR3_2022;
  • replace HLTRUN3 with HLTDR3_2022 (they are identical, making the first redundant);
  • create RECODR3_reHLT (= "RECODR3 + --hltProcess=reHLT");
  • replace RECODR3_2021 with RECODR3_reHLT;
  • rename RECONANORUN3 to RECONANORUN3_reHLT, and base it off of RECODR3_reHLT;
  • rename RECOCOSMRUN3 to RECOCOSMRUN3_reHLT.

@rappoccio
Copy link
Contributor

+1

  • Not a verbatim backport but appropriate for this release.

@cmsbuild cmsbuild merged commit 262ba3b into cms-sw:CMSSW_12_5_X Oct 31, 2022
@missirol missirol deleted the devel_reHLTRelValFix_125X branch October 31, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed orp-approved pdmv-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.
6 participants
@missirol @cmsbuild @kskovpen @srimanob @perrotta @rappoccio