Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_5_X] Raw prime wf for Run 3 data w/ dropped strips + approx. clusters #39883

Merged

Conversation

mandrenguyen
Copy link
Contributor

backport of #39863

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 27, 2022

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_12_5_X.

It involves the following packages:

  • Configuration/EventContent (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • EventFilter/RawDataCollector (daq)
  • RecoLocalTracker/SiStripClusterizer (reconstruction)

@perrotta, @rappoccio, @bbilin, @emeschi, @clacaputo, @smorovic, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET, @mandrenguyen, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@echabert, @VourMa, @felicepantaleo, @yduhm, @robervalwalsh, @kpedro88, @Martin-Grunewald, @trtomei, @threus, @slomeo, @makortel, @JanFSchulte, @dgulhan, @missirol, @beaucero, @GiacomoSguazzoni, @rovere, @VinInn, @alesaggio, @mmusich, @mtosi, @fabiocos, @swertz, @gbenelli, @lecriste, @gpetruc, @sameasy this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4129a1/28577/summary.html
COMMIT: 57f290b
CMSSW: CMSSW_12_5_X_2022-10-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39883/28577/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3697216
  • DQMHistoTests: Total failures: 142
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697052
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Pull request #39883 was updated. @perrotta, @rappoccio, @bbilin, @emeschi, @clacaputo, @smorovic, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET, @mandrenguyen, @fabiocos, @davidlange6 can you please check and sign again.

@mandrenguyen
Copy link
Contributor Author

please test

@mandrenguyen
Copy link
Contributor Author

urgent
needed for a new release to be part of the heavy-ion test next Monday (november 7)

@mandrenguyen
Copy link
Contributor Author

+reconstruction

@smorovic
Copy link
Contributor

+daq

@rappoccio
Copy link
Contributor

@cms-sw/daq-l2 can you please sign the master PR as well so we can get this in ASAP?

#39863

@AdrianoDee
Copy link
Contributor

+upgrade

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

@cms-sw/pdmv-l2 please let us know if you have any issue about this backport

@kskovpen
Copy link
Contributor

kskovpen commented Nov 2, 2022

+pdmv

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 2796da7 into cms-sw:CMSSW_12_5_X Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants