-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update of L1TGlobalProducer
to handle fractional prescales [12_5_X
]
#39851
update of L1TGlobalProducer
to handle fractional prescales [12_5_X
]
#39851
Conversation
A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_5_X. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-363f57/28507/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
This PR should be merged "with" (same IB), or after, cms-sw/cmsdist#8146. |
+1 |
backport of #39464
backport of #39832
PR description:
This PR backports #39464 and #39832. The first one is a fix by the L1T group to correctly apply fractional prescales in L1T software (needed, for example, for the development of the HIon menu); the 2nd PR is a technical follow-up of the 1st one, adding a unit test and small technical improvements.
Because of #39832, this PR requires the backport of cms-sw/cmsdist#8140 to the
12_5_X
branch ofcmsdist
.On top of the backports, there is one more commit (844f35a): I had to change the input file of the unit test to use a
12_5_X
file.FYI: @elfontan @mitaylor
PR validation:
The new unit test passes in local tests.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
#39464
#39832
Fix for offline trigger studies.