Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test of L1TGlobalProducer and small technical updates to GlobalBoard #39832

Merged
merged 1 commit into from
Oct 25, 2022
Merged

unit test of L1TGlobalProducer and small technical updates to GlobalBoard #39832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions L1Trigger/L1TGlobal/interface/GlobalBoard.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include <cassert>
#include <vector>
#include <cmath>
#include <memory>

// user include files
#include "FWCore/Utilities/interface/typedefs.h"
Expand All @@ -40,8 +41,6 @@
#include "DataFormats/L1TGlobal/interface/GlobalExtBlk.h"

#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Utilities/interface/InputTag.h"
#include "FWCore/MessageLogger/interface/MessageLogger.h"
#include "FWCore/Framework/interface/EventSetup.h"

// forward declarations
Expand All @@ -64,7 +63,7 @@ namespace l1t {

public:
/// receive data from Global Muon Trigger
void receiveCaloObjectData(edm::Event&,
void receiveCaloObjectData(const edm::Event&,
const edm::EDGetTokenT<BXVector<l1t::EGamma>>&,
const edm::EDGetTokenT<BXVector<l1t::Tau>>&,
const edm::EDGetTokenT<BXVector<l1t::Jet>>&,
Expand All @@ -77,17 +76,17 @@ namespace l1t {
const int nrL1Jet,
const bool receiveEtSums);

void receiveMuonObjectData(edm::Event&,
void receiveMuonObjectData(const edm::Event&,
const edm::EDGetTokenT<BXVector<l1t::Muon>>&,
const bool receiveMu,
const int nrL1Mu);

void receiveMuonShowerObjectData(edm::Event&,
void receiveMuonShowerObjectData(const edm::Event&,
const edm::EDGetTokenT<BXVector<l1t::MuonShower>>&,
const bool receiveMuShower,
const int nrL1MuShower);

void receiveExternalData(edm::Event&, const edm::EDGetTokenT<BXVector<GlobalExtBlk>>&, const bool receiveExt);
void receiveExternalData(const edm::Event&, const edm::EDGetTokenT<BXVector<GlobalExtBlk>>&, const bool receiveExt);

/// initialize the class (mainly reserve)
void init(const int numberPhysTriggers,
Expand All @@ -100,7 +99,7 @@ namespace l1t {
int bxLast);

/// run the uGT GTL (Conditions and Algorithms)
void runGTL(edm::Event& iEvent,
void runGTL(const edm::Event& iEvent,
const edm::EventSetup& evSetup,
const TriggerMenu* m_l1GtMenu,
const bool produceL1GtObjectMapRecord,
Expand All @@ -114,7 +113,7 @@ namespace l1t {
const int nrL1Jet);

/// run the uGT FDL (Apply Prescales and Veto)
void runFDL(edm::Event& iEvent,
void runFDL(const edm::Event& iEvent,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and elsewhere, the Event arg can be made const.

const int iBxInEvent,
const int totalBxInEvent,
const unsigned int numberPhysTriggers,
Expand Down Expand Up @@ -242,12 +241,10 @@ namespace l1t {

GlobalAlgBlk m_uGtAlgBlk;

// cache of maps
// cache of maps
std::vector<AlgorithmEvaluation::ConditionEvaluationMap> m_conditionResultMaps;

bool m_firstEv;
bool m_firstEvLumiSegment;
uint m_currentLumi;
unsigned int m_currentLumi;

private:
/// verbosity level
Expand Down Expand Up @@ -281,10 +278,11 @@ namespace l1t {

// struct to increment the prescale according to fractional prescale logic in firmware
struct PrescaleCounter {
const size_t prescale_count;
size_t trigger_counter = 0;
size_t const prescale_count;
size_t trigger_counter;

PrescaleCounter(double prescale) : prescale_count(std::lround(prescale * m_singlestep)) {
PrescaleCounter(double prescale, size_t const initial_counter = 0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the 2nd arg to give a handle to set the value of trigger_counter from this ctor, even though this 2nd arg is never used in the current implementation.

: prescale_count(std::lround(prescale * m_singlestep)), trigger_counter(initial_counter) {
if (prescale_count != 0 and (prescale_count < m_singlestep or prescale < 0)) {
throw cms::Exception("PrescaleCounterConstructor")
<< "invalid initialisation of PrescaleCounter: prescale = " << prescale
Expand All @@ -299,12 +297,12 @@ namespace l1t {
// prescale counters: NumberPhysTriggers counters per bunch cross in event
std::vector<std::vector<PrescaleCounter>> m_prescaleCounterAlgoTrig;

// create prescale counters, initialising trigger_counter to a semirandom number between 0 and prescale_count - 1 inclusive
static const std::vector<PrescaleCounter> semirandomNumber(const edm::Event& iEvent,
const std::vector<double>& prescaleFactorsAlgoTrig);

// create prescale counters, initialising trigger_counter to zero
static const std::vector<PrescaleCounter> zeroPrescaleCounters(const std::vector<double>& prescaleFactorsAlgoTrig);
static std::vector<PrescaleCounter> prescaleCounters(std::vector<double> const& prescaleFactorsAlgoTrig);

// create prescale counters, initialising trigger_counter to a semirandom number between 0 and prescale_count - 1 inclusive
static std::vector<PrescaleCounter> prescaleCountersWithSemirandomInitialCounter(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the name of the method to clarify its purpose. I removed the const keyword, b/c I didn't see the advantage of returning a const vector (by value) rather than just returning a vector.

std::vector<double> const& prescaleFactorsAlgoTrig, edm::Event const& iEvent);
};

} // namespace l1t
Expand Down
Loading