Fixing bug in HLTriggerJSONMonitoring L1 and prescale module idenfication : 12_5_X

[Sam-Harper]

PR description:

HLTriggerJSONMonitoring is how the HLT reports path rates to OMS. It was updated in Jun (#38418) to better support DatasetPaths.

In doing so a bug was introduced in that if a path is after a dataset path, the wrong L1 and prescale module will be identified.

Additionally the logic was improved to only consider the first seed module and also to disregard ignored modules. This fixes problems in some paths which have additional L1 seed modules which are ignored as they want to use this data later in the path.

Credit goes to Adelina Lintuluoto (@alintulu) for spotting this issue in the hilton tests.

PR validation:

validation in : #39779

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported

backport of #39779 as its needed to fix a bug in monitoring at P5

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_12_5_X.

It involves the following packages:

• HLTrigger/JSONMonitoring (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @missirol, @Martin-Grunewald, @fwyzard this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fixing bug in HLTriggerJSONMonitoring L1 and prescale module idenfication #39779

[Sam-Harper]

please test

[missirol]

backport of #39779

[missirol]

type bugfix

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4c6cc/28422/summary.html
COMMIT: e0e5417
CMSSW: CMSSW_12_5_X_2022-10-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39811/28422/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 10825.010825.0_ZEE_13+2018+ZEE_13TeV_TuneCUETP8M1_GenSimINPUT+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step2_ZEE_13+2018+ZEE_13TeV_TuneCUETP8M1_GenSimINPUT+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3697216
• DQMHistoTests: Total failures: 1098
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3696096
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

• RelVals-INPUT error is very likely unrelated to this PR
• differences in wf 11634.7 cannot be caused by this PR, and were seen recently elsewhere (spurious differences in outputs of Run-3 wfs *.7 #39803)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge