Switch to TICLv4 for offline HGCAL electrons and photons

[SohamBhattacharya]

PR description:

This PR switches to TICLv4 for offline HGCAL electrons and photons.

The following plots were obtained using these samples:

• SingleElectron_Pt-2To200-gun/PhaseIISpring22DRMiniAOD-PU200_123X_mcRun4_realistic_v11-v1/GEN-SIM-DIGI-RAW-MINIAOD
• SinglePhoton_Pt-2To200-gun/PhaseIISpring22DRMiniAOD-PU200_123X_mcRun4_realistic_v11-v1/GEN-SIM-DIGI-RAW-MINIAOD

Expected consequences:

• The electron reco efficiency should increase:
  

• The photon reco efficiency should increase:
  

• The electron mis-reco (i.e. reco electrons not $\Delta R$ matched to any gen-electron) efficiency should not change much:
  

• The photon mis-reco (i.e. reco-photons not $\Delta R$ matched to any gen-photons) efficiency should not change much:
  

• The electron and photon energy responses (recoE/genE) should remain fairly the same.

@swagata87 @rovere @felicepantaleo

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39810/32680

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @SohamBhattacharya for master.

It involves the following packages:

• RecoParticleFlow/PFClusterProducer (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@mmarionncern, @felicepantaleo, @rovere, @lgray, @missirol, @lecriste, @hatakeyamak, @ebrondol, @sameasy, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[rovere]

@cmsbuild please test

[AdrianoDee]

assign upgrade
(to have the tag and be notified)

[cmsbuild]

New categories assigned: upgrade

@AdrianoDee,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d82430/28417/summary.html
COMMIT: ee85039
CMSSW: CMSSW_12_6_X_2022-10-20-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39810/28417/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1067 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 2949
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3388187
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[AdrianoDee]

@cmsbuild enable profiling

[rovere]

enable profiling

[rovere]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d82430/28425/summary.html
COMMIT: ee85039
CMSSW: CMSSW_12_6_X_2022-10-21-1100/el8_amd64_gcc10
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39810/28425/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1070 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3378384
• DQMHistoTests: Total failures: 2949
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3375413
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[rovere]

@SohamBhattacharya thanks! the timing went down considerably as well with this PR.
I believe, once integrated, this will address #39482

[swagata87]

indeed, I am looking at WF 21034.21, and there are some timing reductions for electron related modules. For example:

Rank			Total%	 		Cumulative					Delta						Symbol name
[1    -> 23  ] [5.9    -> 0.7   ]  [102.23    -> 10.03    ]         [ 10.03    /1456.79   - 102.23   /1732.13   *100% ] = [-5.21 % ]         ElectronSeedProducer::produce    
                 
[0    -> 0   ] [14.2   -> 13.1  ]  [246.21    -> 190.39   ]         [ 190.39   /1456.79   - 246.21   /1732.13   *100% ] = [-1.15 % ]         cms::CkfTrackCandidateMakerBase::produceBase      

[clacaputo]

+reconstruction

• clear reduction in cpu timing for 21034.21 Switch to TICLv4 for offline HGCAL electrons and photons #39810 (comment)
• some minor differences in reco slimmedElectronsHGC mostly due to changes in the number of entries

[AdrianoDee]

+upgrade

• addressing [12_6_0_pre2] Reco timing increase in Phase2 reconstruction #39482

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1