duplicated hcalDepthTowerSumEt in GsfElectron.h

[ravindkv]

PR description:

There was a typo due to which the same variable (hcalDepth1TowerSumEt) was added to itself instead of with hcalDepth2TowerSumEt.

PR validation:

The change is just in one line of the header file (GsfElectron.h) which was pointed (and possibly validated) in the following thread:
https://cms-talk.web.cern.ch/t/duplicated-codes-in-gsfelectron-h/16202

@swagata87, please let me know in case further checks are to be performed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39805/32676

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @ravindkv (Ravindra K Verma) for master.

It involves the following packages:

• DataFormats/EgammaCandidates (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @Prasant1993, @rovere, @lgray, @missirol, @sobhatta, @afiqaize, @wrtabb, @sameasy, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[swagata87]

type bugfix

The bug does not affect anything for Run3.
The bug was introduced when egamma moved from CaloTower-based HCAL-related ID variables to HCAL recHit based ID variables, in this PR which had an exceptionally long change-log (#33666), but the bug is in that part of the code which is meant to keep backward compatibility.

[swagata87]

type egamma

[swagata87]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55db55/28413/summary.html
COMMIT: 733ed55
CMSSW: CMSSW_12_6_X_2022-10-20-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39805/28413/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391133
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[clacaputo]

+reconstruction

• bugfix
• code changes don't affect Run3, see duplicated hcalDepthTowerSumEt in GsfElectron.h #39805 (comment)
• no reco changes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1