-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update & bug fix for offline DQM for EXO & HIG Run 3 muon paths #39799
Conversation
…tersNoVtx_v and HLT_TrkMu17_DoubleTrkMu8NoFiltersNoVtx_v; make it not required to have all paths valid in the numerator and denominator
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39799/32669
|
A new Pull Request was created by @jalimena (Juliette Alimena) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b2ef5/28411/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
1 similar comment
+1 |
PR description:
This PR:
HLT_TrkMu16_DoubleTrkMu6NoFiltersNoVtx_v
andHLT_TrkMu17_DoubleTrkMu8NoFiltersNoVtx_v
MuonMonitor_cff
The reason for the second part is because in the HLT 2022 v1.3 menu, one of the paths in the denominator was removed. As a result, the DQM plots did not get made, although they would have been fine, physics-wise. Changing this flag to false is the easiest way to have similar DQM plots with the earlier and later HLT menus, and it fixes this bug.
As a result of this PR, some DQM plots will be removed, and some will reappear.
PR validation:
Using the 11634.0 ttbar workflow, I have tested that the correct histograms are produced and filled in the harvested DQM file.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR will need to be backported to 12_4_X, so it will go into the DQM offline GUI.