loosen check on ntuplet size in GPUCACell::find_ntuplets

[missirol]

PR description:

This PR implements a suggestion from @fwyzard and @VinInn to fix the last outstanding issue of those described in #38453.

It loosens an assert check used (on CPU) in the building of pixel-track candidates at HLT.

PR validation:

The remaining crash reported in #38453 (#38453 (comment)) does not occur with this PR.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_12_4_X
CMSSW_12_5_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39780/32647

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoPixelVertexing/PixelTriplets/plugins/GPUCACell.h modified in PR(s): Tracker Traits and Enabling Phase2 for Inner Tracker Reconstruction on GPU #38761

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• RecoPixelVertexing/PixelTriplets (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

enable gpu

Even though assert calls are anyway removed on GPU (see #38453 (comment)).

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a419a0/28373/summary.html
COMMIT: f23bd6e
CMSSW: CMSSW_12_6_X_2022-10-19-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39780/28373/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 16 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391121
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19876
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19867
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[missirol]

assign tracking-pog

Like for other recent HLT fixes, good to ask the sign-off of the relevant experts.

[cmsbuild]

New categories assigned: tracking-pog

@slava77,@mmusich you have been requested to review this Pull request/Issue and eventually sign? Thanks

[mmusich]

+1

• the fix has been tested explicitly using the recipe below¹ (see also HLT crashes in GPU and CPU in collision runs #38453 (comment))
• the primary author of the original code approved the changes, see HLT crashes in GPU and CPU in collision runs #38453 (comment)

Footnotes

1. cmsrel CMSSW_12_4_10_patch2
   cd CMSSW_12_4_10_patch2/src/
   cmsenv
   git cms-addpkg RecoPixelVertexing/PixelTriplets
   git-fetch-user missirol
   git cherry-pick f23bd6e
   scramv1 b -j 20
   cp -pr /afs/cern.ch/user/t/tomei/public/issue38453 .
   cd issue38453/
   cmsRun hlt_for_debug.py ↩

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

urgent

• @cms-sw/orp-l2 I think we should consider building a patch3 with the backport of this one: loosen check on ntuplet size in GPUCACell::find_ntuplets [12_4_X] #39782

[perrotta]

+1