Revert "Implement support for concurrent runs in the Framework"

[perrotta]

Reverts #38801

Preparing a revert pr in case the issue reported in #38801 (comment) cannot get fixed quickly, and we want to cut 12_6_0_pre3

Hopefully this will get closed without merging

@makortel @wddgit

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39642/32442

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Framework/interface/EventSetupsController.h modified in PR(s): Move EventSetup module PSet validation to be called from ComponentMaker #39556
  • File FWCore/Framework/interface/global/EDFilterBase.h modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/interface/global/EDProducerBase.h modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/interface/global/implementors.h modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/interface/limited/EDFilterBase.h modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/interface/limited/EDProducerBase.h modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/interface/limited/implementors.h modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/interface/one/EDFilterBase.h modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/interface/one/EDProducerBase.h modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/interface/one/implementors.h modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/interface/stream/ProducingModuleAdaptorBase.h modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Move EventSetup module PSet validation to be called from ComponentMaker #39556
  • File FWCore/Framework/src/EventSetupsController.cc modified in PR(s): Move EventSetup module PSet validation to be called from ComponentMaker #39556
  • File FWCore/Framework/src/global/EDFilterBase.cc modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/src/global/EDProducerBase.cc modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/src/limited/EDFilterBase.cc modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/src/limited/EDProducerBase.cc modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/src/one/EDFilterBase.cc modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/src/one/EDProducerBase.cc modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/src/stream/ProducingModuleAdaptorBase.cc modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/test/global_filter_t.cppunit.cc modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Framework/test/global_producer_t.cppunit.cc modified in PR(s): Added transformAsync ability to modules #39557
  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Added transformAsync ability to modules #39557

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• FWCore/Framework (core)
• FWCore/Integration (core)
• FWCore/ParameterSet (core)
• FWCore/TFWLiteSelector (core)
• FWCore/TestProcessor (core)
• IOPool/Input (core)
• Mixing/Base (simulation)

@smuzaffar, @civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @missirol, @fabiocos, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[perrotta]

@cmsbuild please test

[aandvalenzuela]

please test

• Tests need to be restarted due to a failure in cvmfs.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4615ea/28055/summary.html
COMMIT: a2d3721
CMSSW: CMSSW_12_6_X_2022-10-05-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39642/28055/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4615ea/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3391103
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391081
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[perrotta]

Tests succeed, then it can be reverted
@rappoccio @makortel @wddgit I'd go ahead with the plan of merging this to have a clean pre3, then, and create a revert-of-revert PR to recreate the original #38801. Or maybe this is something that you should better do yourself, maybe starting from the original commit, if you intend to apply further fixes already to it

[rappoccio]

+1

[rappoccio]

Will wait for this to finish in IBs and then build pre3. We can discuss a clean solution for #39644 in a few days.