-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GE21-ME21 segment reconstruction (backport of #39441, 12_5_X) #39597
GE21-ME21 segment reconstruction (backport of #39441, 12_5_X) #39597
Conversation
a backport of slowmoyang:ge21-me21-seg-reco__from-CMSSW_12_6_0_pre2
A new Pull Request was created by @slowmoyang (slowmoyang) for CMSSW_12_5_X. It involves the following packages:
@perrotta, @rappoccio, @pmandrik, @mandrenguyen, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @clacaputo, @syuvivida, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
please test
|
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestDQMOnlineClient-dt_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-hlt_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-beampixel_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-fed_dqm_sourceclient had ERRORS and more ... Comparison SummarySummary:
|
@cms-sw/dqm-l2 or @slowmoyang Do you have an idea why the unit tests are failing here? |
@mandrenguyen see #39669 |
@emanueleusai I believe the conclusion from the ORP was that we should simply ignore the unit tests, right? |
alright then we'll proceed with the tests at P5 o the 12_4 backport of this |
backport of #39441 |
+1
|
+1 |
@cmsbuild please test Retrigger the test after 3 weeks. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2802c5/28493/summary.html Comparison SummarySummary:
|
+Upgrade |
please hold
|
Since the 12_5 is out, and Phase-2 campaign starts, do we still expect this backport? |
Backport not needed any more (it was merged in the online DQM release, anyhow) |
PR description:
Backport of #39441. This PR introduces the GE21-ME21 segment reconstruction.
PR validation:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is a backport of #39441. This update is required for the GEM online DQM.
@jshlee @watson-ij