-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Validation/Geometry to D92 #39590
Conversation
Full test is done in #39571 (comment) |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39590/32389
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @emanueleusai, @ianna, @ahmad3213, @cmsbuild, @bsunanda, @jfernan2, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc3c29/27976/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@cms-sw/geometry-l2 @cms-sw/dqm-l2 with this (simple) fix the unit test materialBudgetHGCalPlot now succeed, instead of failing as in the IBs. Would you agree signing, so that this fix can be included already in pre3? |
+1 fixes are obvious |
+1
|
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR provided fix of unit test after #38702 was merged. Discussion is in #38594 (comment)
PR validation:
None. To be tested with #39571 and #39572
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport and no need of backport.