Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_6_X] RPCOccupancyTest crash protection for 0 LS #39559

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

pmandrik
Copy link
Contributor

@pmandrik pmandrik commented Oct 1, 2022

PR description:

See #39558

@cmsbuild cmsbuild changed the base branch from CMSSW_12_6_X to master October 1, 2022 02:50
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2022

@pmandrik, CMSSW_12_6_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@pmandrik
Copy link
Contributor Author

pmandrik commented Oct 1, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2022

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39559/32349

  • This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@pmandrik
Copy link
Contributor Author

pmandrik commented Oct 3, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39559/32366

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2022

A new Pull Request was created by @pmandrik (Petr Mandrik) for master.

It involves the following packages:

  • DQM/RPCMonitorClient (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@acimmino this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a995b0/27960/summary.html
COMMIT: c9b0bd6
CMSSW: CMSSW_12_6_X_2022-10-03-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39559/27960/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a995b0/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432650
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3432622
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Oct 4, 2022

@cms-sw/dqm-l2 signing a backport PR implies, amongst other thimgs, that you verified that the master version of the PR run without errors and behaved as expected. You already signed the backports of this PR: either sign also this one, or remove the signatures in the two backport ones while waiting for evaluating this one in the master

@emanueleusai
Copy link
Member

+1

1 similar comment
@perrotta
Copy link
Contributor

perrotta commented Oct 5, 2022

+1

@perrotta
Copy link
Contributor

perrotta commented Oct 5, 2022

ping bot

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit e572ac7 into cms-sw:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants