-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read SoA scalars and Eigen columns from a ROOT streamer [12.5.x] #39533
Conversation
backport #39532 |
type bugfix |
enable gpu |
please test |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_5_X. It involves the following packages:
@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test testHeterogeneousCoreAlpakaTestWriteRead had ERRORS Comparison SummarySummary:
GPU Comparison SummarySummary:
|
848368c
to
6fb6335
Compare
please test |
Move the printout before the assert, so it can provide more details if the assertion fails.
Store Eigen SoA columns as a strided, linearised array, and implement a ROOT streamer for reading them back as Eigen objects in SoA columns. Update the CUDA and Alpaka portable collection tests to fill the Eigen Matrix column, print part of its content, and check that it is written and read back correctly.
b4f48b0
to
954edbc
Compare
test parameters:
|
please test |
please test |
please test with cms-sw/cmsdist#8108 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e38aa6/27867/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+heterogeneous |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Fix the ROOT streamers for the template-based SoA to read back the scalar variables, and to write and read back Eigen objects.
Update the
TestAlpakaAnalyzer
and CUDATestPortableAnalyzer
to check that scalars and matrices are read back correctly, and print a more verbose description of the SoA being read.Update the test scripts so that the unit tests actually fail (exit with a non-zero value) if any of the cmsRun jobs fails.
PR validation:
The improved unit tests pass.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #39532 to CMSSW_12_5_X for the Alpaka migration.