Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12_5_X] Use "best matching" EDAlias in module dependence checks when placing ConditionalTask modules in Path #39529

Merged
merged 1 commit into from
Oct 1, 2022
Merged

[12_5_X] Use "best matching" EDAlias in module dependence checks when placing ConditionalTask modules in Path #39529

merged 1 commit into from
Oct 1, 2022

Conversation

makortel
Copy link
Contributor

PR description:

Backport of #39409. From original description

This PR fixes the problem reported in #36938 (comment). If the EDAlias has wildcards for one module, and more specific aliases for another module, we should use the one that has the most constrained match. There is one ambiguous case left, for which an exception is thrown. I hope we won't encounter that situation in practice.

PR validation:

None beyond #39409

@makortel
Use "best matching" EDAlias in module dependence checks when placing …
b383640 
…ConditionalTask modules in Path

If the EDAlias has wildcards for one module, and more specific aliases
for another module, we should use the one that has the most
constrained match. There is one ambiguous case left, for which an
exception is thrown. I hope we won't encounter that situation in
practice.

The problem was encountered with a SwitchProducer having the EDAlias
case, but I think the problem could happen also without
SwitchProducer.
@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Sep 28, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 28, 2022 •
edited
Loading

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_12_5_X.

It involves the following packages:

  • FWCore/Framework (core)
  • FWCore/Integration (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@makortel makortel changed the title [12_5_X] Use "best matching" EDAlias in module dependence checks when placing ConditionalTask modules in Pat [12_5_X] Use "best matching" EDAlias in module dependence checks when placing ConditionalTask modules in Path Sep 28, 2022
@makortel
Copy link
Contributor Author

type bug-fix

@makortel
Copy link
Contributor Author

backport of #39409

This was referenced Sep 28, 2022
Open
Closed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ab44b/27828/summary.html
COMMIT: b383640
CMSSW: CMSSW_12_5_X_2022-09-28-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39529/27828/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3699454
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3699424
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 1, 2022

+1

@cmsbuild cmsbuild merged commit e2242aa into cms-sw:CMSSW_12_5_X Oct 1, 2022
@makortel makortel deleted the fixSwitchProducerEDAliasConditionalTask_125x branch October 3, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok bug-fix core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.
3 participants
@makortel @cmsbuild @perrotta