-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed misnamed files in EcalTPG unittest script #39503
Conversation
A new Pull Request was created by @perrotta (Andrea Perrotta) for CMSSW_12_5_X. It involves the following packages:
@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
Thanks a lot @perrotta for creating the backport! |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e81f01/27778/summary.html Comparison SummarySummary:
|
+db
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #39235
This PR fixes the issue #38964 created in CondTools/Ecal unittests by the merged PR #38856. The issue was still present in 12_5_X, but the fix was only submitted for the master, 12_6_X (as noticed by @makortel in #39485 (comment))
Two different unit tests were writing on the same local sqlite file, causing troubles. The output files are now unique.