Add calibration fit plot to the PPS HPTDC PCL

[ChrisMisan]

PR description:

New per-channel plot was added to the harvester, it allows to investigate produced calibration fit. Plot is saved together with all of the worker plots after the harvesting stage.

PR validation:

wfs 1041, 1044

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport to 12_5 and 12_4 will follow.

[ChrisMisan]

type ctpps, new-feature

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39493/32235

ERROR: Build errors found during clang-tidy run.

CalibPPS/TimingCalibration/plugins/PPSTimingCalibrationPCLHarvester.cc:149:62: error: expected ')' [clang-diagnostic-error]
        calib_time[key] = std::make_pair(offset_, resolution_;  // hardcoded offset/resolution placeholder for the time being
                                                             ^
CalibPPS/TimingCalibration/plugins/PPSTimingCalibrationPCLHarvester.cc:149:41: note: to match this '('
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39493/32236

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @ChrisMisan (Christopher) for master.

It involves the following packages:

• CalibPPS/TimingCalibration (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@fabferro, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

test parameters:

• workflows=1041,1044

[ChrisMisan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70aa88/27758/summary.html
COMMIT: e209d9d
CMSSW: CMSSW_12_6_X_2022-09-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39493/27758/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70aa88/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70aa88/1044.0_RunRawPPS2022B+RunRawPPS2022B+TIER0EXPPPSCALRUN3+ALCASPLITPPSCALRUN3+ALCAHARVDPPSCALRUN3

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 3624944
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3624920
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 50.939 KiB( 52 files compared)
• DQMHistoSizes: changed ( 1044.0 ): 50.939 KiB AlCaReco/PPSTimingCalibrationPCL
• Checked 220 log files, 49 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• 1041, 1044 wf-s pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1