Call RootHandlers::willBeUsingThreads() based on number of threads rather than streams

[makortel]

PR description:

While working on something else I noticed EventProcessor calls RootHandlers::willBeUsingThreads() if the job was configured to use more than one stream. Given what InitRootHandlers::willBeUsingThreads() does

cmssw/FWCore/Services/plugins/InitRootHandlers.cc

Lines 874 to 883 in a2ee5cb

	void InitRootHandlers::willBeUsingThreads() {
	//Tell Root we want to be multi-threaded
	ROOT::EnableThreadSafety();
	//When threading, also have to keep ROOT from logging all TObjects into a list
	TObject::SetObjectStat(false);
	//Have to avoid having Streamers modify themselves after they have been used
	TVirtualStreamerInfo::Optimize(false);
	}

I'd think the check should be based on the number of threads (thinking of a job with one stream and at least two threads).

PR validation:

None (edited on the web editor)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39475/32208

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Modified data product delete early system #38983, Implement support for concurrent runs in the Framework #38801

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• FWCore/Framework (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[makortel]

@Dr15Jones, @dan131riley Would you agree?

[Dr15Jones]

Would you agree?

yes

[dan131riley]

@Dr15Jones, @dan131riley Would you agree?

Yes

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-708c65/27725/summary.html
COMMIT: b0af373
CMSSW: CMSSW_12_6_X_2022-09-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39475/27725/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @makortel Add missing includes to two AlpakaCore headers #39463

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-708c65/27725/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-708c65/27725/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3624368
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3624332
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1