-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_5_X] [L1T] Backport of: Phase-2, include missing collections in outputs #39451
Conversation
backport of #39401 |
A new Pull Request was created by @cecilecaillol for CMSSW_12_5_X. It involves the following packages:
@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06bf02/27665/summary.html Comparison SummarySummary:
|
+l1 |
eadfae7
to
2f0faab
Compare
Pull request #39451 was updated. @rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06bf02/27928/summary.html Comparison SummarySummary:
|
+l1 |
@cecilecaillol @BenjaminRS I assume all these collections are needed, and therefore the master PR had just been signed. Nonetheless, in this backport PR could you please add an estimate of the increase of the event size, possibly already in the PR description? |
+Upgrade Backport PR. Waiting for size estimation for additional collections. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Note to @perrotta @rappoccio |
@@ -220,7 +220,7 @@ void HPSPFTauProducer::fillDescriptions(edm::ConfigurationDescriptions& descript | |||
desc.add<double>("minSeedJetPt", 30.0); | |||
desc.add<double>("maxChargedRelIso", 1.0); | |||
desc.add<double>("minSeedChargedPFCandPt", 5.0); | |||
desc.add<edm::InputTag>("srcL1PFCands", edm::InputTag("l1ctLayer1", "PF")); | |||
desc.add<edm::InputTag>("srcL1PFCands", edm::InputTag("l1tLayer1", "PF")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a bug, or the bug is in the master instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this line will be overwritten by
https://github.com/cms-sw/cmssw/blob/master/L1Trigger/Phase2L1Taus/python/HPSPFTauProducerPF_cfi.py#L5
srcL1PFCands = "l1tLayer1:PF",
However, let's @cms-sw/l1-l2 confirms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this line will be overwritten by https://github.com/cms-sw/cmssw/blob/master/L1Trigger/Phase2L1Taus/python/HPSPFTauProducerPF_cfi.py#L5
srcL1PFCands = "l1tLayer1:PF",
Sure, it is overwritten.
But it changes the default.
Can we have the correct default in both master and backports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Let's spend a little time to clean up things.
In addition, I see few places in master that still use l1ctLayer1
which I assume them to change to l1tLayer1
https://github.com/cms-sw/cmssw/search?q=l1ctLayer1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is correct. I will make a bug-fix PR to master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR to master with the fixes: #39704
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cecilecaillol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes: #39705
@cecilecaillol besides #39451 (review) (which must be clarified) this is a verbatim backport of #39401 and #39499. Once that gets fixed, this PR can be merged in 12_5. Before merging, please also provide an estimate of the increase in the event size, as it was already requested long time ago. A gross estimate is enough, and it should be rather simple to derive it starting from the data samples you have at hand. |
@cecilecaillol ping on this? |
Regarding the size, measure with TTbar PU200 The collections (listed belowed) add 12776.2 Bytes/Event (Average Compressed Size)
These collections are not available in CMSSW_12_6_0_pre2 relvals. I use relvals to x-check if the above collections are added on top as expected. |
+1
|
PR description:
This PR addresses the missing Tk object collections in the CMSSW_12_5_0_pre5 RelVals. It includes fixes were needed to avoid errors after adding in the objects to the EventContent. One error that came up in the FEVTDEBUGHLToutput_step was: The class "l1t::TkJetWord" is compiled and for its data member "tkJetWord_" we do not have a dictionary for the collection "bitset<70>". Because of this, we will not be able to read or write this data member.
classes_def.xml was adjusted to avoid the error. Local PR: cms-l1t-offline#1048
This PR also adds missing collections for Phase 2 tau-jet-met to the event content. Specifically the 9x9 Sums for histogrammed jets, the NN Puppi taus, and the HPS taus. Local PR: cms-l1t-offline#1047
We need this PR in 12_5 for our Phase-2 L1 MC production
Backport of #39401 and #39499