[12_4_X] Added protection against out-of-range BX values in EMTF unpacker blocks

[eyigitba]

PR description:

This PR is a partial backport of #38961. The rest of the changes will go in with #39389

The PR was made as discussed in #39388

This PR fixes the crash reported in #38940. EMTF DAQ readout window is 7 BX wide [-3, 3], but in cases of corrupted data from TPs or faulty configurations it can have a value of 4.

Apaprently, such cases happened during LS2 when GEMs were not working properly. Unpacking this data and trying to use the DQM plots added in #38818 causes a crash.

This PR adds a veto for any TP or EMTF track that falls out of this [-3, 3] window since these are clearly not valid.

PR validation:

Validated with the failing workflows from #38940. Everything works and we print out the warning messages about corrupted data.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a partial backport of #38961. The rest of the changes will go in with #39389

The PR was made as discussed in #39388

[cmsbuild]

A new Pull Request was created by @eyigitba for CMSSW_12_4_X.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Added protection against out-of-range BX values in EMTF unpacker blocks #38961

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42b349/27596/summary.html
COMMIT: a7a3942
CMSSW: CMSSW_12_4_X_2022-09-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39413/27596/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677396
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3677366
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

please test
(The das error in the unit test is clearly unrelated. Let relaunch the tests, if this helps the signature)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42b349/27626/summary.html
COMMIT: a7a3942
CMSSW: CMSSW_12_4_X_2022-09-17-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39413/27626/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677402
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3677378
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

backport of #38961
(already partially backported in 12_4_X with #39389)

[perrotta]

I was ready to bypass the @cms-sw/l1-l2 signature and merge this PR for the next 12_4_X data taking release.
However, if I'm not wrong #38818 (the DQM plots added by whom caused the segfault fixed by the backported PR) was never backported into 12_4:_X. Therefore it is probably not strictly necessary having this PR in 12_4_X: let it follow the usual signature procedure, and merge it eventually only if needed.

[eyigitba]

@perrotta , yes #38818 was never backported to 12_4_X. That's why I said this is probably not that urgent in my original comment. I think it's still better to have it go in for consistency though. I'm ok with following the usual signature procedure since there is no rush

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1