-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not drop pixel duplicates for phase-2 IT reconstruction #39407
Conversation
ad5a6f2
to
218f9de
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39407/32115
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42dd8f/27580/summary.html Comparison SummarySummary:
|
Seems to have the desired effect, consistent with 2% recovery of tracks for Phase 2: Reading thru the issue, it would be good to have some feedback from @cms-sw/simulation-l2 |
I am not sure we can have a fix from "first principles" in the time-frame of CMSSW_12_5_0 (@cms-sw/orp-l2 can you comment on the ETA ?) and the backport of this PR #39443 afaiu would be needed (see discussion at #39007 (comment)) |
My understanding is that 12_5_0 is to be cut tomorrow. So @mandrenguyen I think it would be nice to merge this in master asap (so the backport can see this aired in an IB for 24 hours) |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Poor man solution to #39007.
PR #37559 has created a serious deterioration of the phase-2 track reconstruction (see https://cms-talk.web.cern.ch/t/new-validation-campaign-12-5-0-pre5-phase2-d88-added/14722/15), likely due to pixels being killed in the middle of the cluster when a PU simHit comes to overlap with a signal simHit.
This PR introduces a
DropDuplicates
parameters in PixelThresholdClusterizer.cc and turns that off for all phase-2 reconstruction.Same mechanism was introduced (only for the heterogeneous version of the reconstruction) at #38761, that would have to be rebased if this PR is merged.
PR validation:
cmssw
compilesIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but will have to be backported if accepted
cc:
@AdrianoDee