-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the NVProfilerService
and ProcessCallGraph
#39398
Fix the NVProfilerService
and ProcessCallGraph
#39398
Conversation
Using a static local variable results in invalid ids when multiple ProcessCallGraph instances are used e.g. by different Services.
Use a ProcessCallGraph to get the highest possible module id, instead of relaying on the modules count.
type bugfix |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39398/32104
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
@makortel, @missirol, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+heterogeneous |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61daf4/27566/summary.html Comparison SummarySummary:
|
+hlt Simply trusting @fwyzard. I don't know enough to judge these changes. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Implement a couple of fixes for the
ProcessCallGraph
:Source
module is added exactly once to theProcessCallGraph
;ProcessCallGraph
instances are used e.g. by different Services.Fix the
NVProfilerService
to for the case where the number of modules in the current process is not a valid indicator of the highest module id, for example if some modules have been destroyed because they cannot be part of any schedule. Instead, use aProcessCallGraph
to get the highest possible module id.PR validation:
With these changes, adding the
NVProfilerService
to complex configurations (e.g. a full HLT menu) works, instead of failing with an assertion.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 12.4.x and 12.5.x for data taking.