Split L1TMuonPhase2/Constants.h header and move Phase2L1GMT private headers in to plugins

[smuzaffar]

UBSAN IBs are broken after the merge of #37358 . The header https://github.com/cms-sw/cmssw/blob/master/DataFormats/L1TMuonPhase2/interface/Constants.h and compilation flags -fsanitize=undefined (used for UBSAN Ibs) do not go well. Compiler takes hours to compile all compilation units where this header is included.

This PR breaks DataFormats/L1TMuonPhase2/interface/Constants.h header move the part of it's contents to L1Trigger/Phase2L1GMT/plugins/Constants.h. Also it disabled the -fsanitize=undefined flag for Phase2L1TGMTProducer.cc which actually include this header.

This change should have no effects and it will fix the UBSAN builds

[a]

8730 00:00:02                                          \_ /cvmfs/cms-ib.cern.ch/nweek-02750/el8_amd64_gcc10/external/gmake/4.3-c4a96629837dd30c3fcd8f20831359f1/bin/gmake -r -f tmp/el8_amd64_gcc10/Makefile -j 10
 9486 00:00:00                                              \_ /bin/sh -c [ -d tmp/el8_amd64_gcc10/src/L1Trigger/Phase2L1GMT/plugins/Phase2L1GMTPlugins ] ||  /usr/bin/mkdir -p tmp/el8_amd64_gcc10/src/L1Trigger/Phase2L1GMT/plugins/Phase2L1GMTPlugins & ----  gcc10/src/L1Trigger/Phase2L1GMT/plugins/Phase2L1GMTPlugins/Phase2L1TGMTProducer.cc.d && exit 1))  
 9492 00:00:00                                                  \_ /bin/sh -c [ -d tmp/el8_amd64_gcc10/src/L1Trigger/Phase2L1GMT/plugins/Phase2L1GMTPlugins ] ||  /usr/bin/mkdir -p tmp/el8_amd64_gcc10/src/L1Trigger/Phase2L1GMT/plugins/Phase2L1GMTPlugi ----  gcc10/src/L1Trigger/Phase2L1GMT/plugins/Phase2L1GMTPlugins/Phase2L1TGMTProducer.cc.d && exit 1))  
 9494 00:00:00                                                      \_ /cvmfs/cms-ib.cern.ch/nweek-02750/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DEIGEN_DONT_PARALLELIZE -DTBB_USE_GLIBCX ----  tmp/el8_amd64_gcc10/src/L1Trigger/Phase2L1GMT/plugins/Phase2L1GMTPlugins/Phase2L1TGMTProducer.cc.o
 9498 00:08:22                                                          \_ /cvmfs/cms-ib.cern.ch/nweek-02750/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../libexec/gcc/x86_64-redhat-linux-gnu/10.3.0/cc1plus -quiet -I /bui ----  fsanitize=pointer-overflow -fPIC --param=vect-max-version-for-alias-checks=50 -fabi-version=0 -o -
 9502 00:00:00                                                          \_ /cvmfs/cms-ib.cern.ch/nweek-02750/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-redhat-linux-gnu/10.3.0/../../../../x86_64-redhat- ----  tmp/el8_amd64_gcc10/src/L1Trigger/Phase2L1GMT/plugins/Phase2L1GMTPlugins/Phase2L1TGMTProducer.cc.o

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39396/32101

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• DataFormats/L1TMuonPhase2 (l1)
• L1Trigger/Phase2L1GMT (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@JanFSchulte, @rovere, @eyigitba, @Martin-Grunewald, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6c9aa/27562/summary.html
COMMIT: d9ee456
CMSSW: CMSSW_12_6_X_2022-09-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39396/27562/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3618326
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3618296
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[smuzaffar]

urgent

@cms-sw/l1-l2 , can you please review this ? This should allow us to start building UBSAN IBs again

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

Thank you @smuzaffar
#37358 was merged already in 12_4: I think this needs to be backported also to 12_4 and 12_5, then: could you please also take care of it?

[perrotta]

+1

[smuzaffar]

Thank you @smuzaffar #37358 was merged already in 12_4: I think this needs to be backported also to 12_4 and 12_5, then: could you please also take care of it?

sure, I will open PRs for 12.4 and 12.5 too