Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlCa Run3 Heavy Ion scenarios #39387

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented Sep 13, 2022

PR description:

This is a tentative to integrate the AlCa related Run3 scenarios for the HI Run.

We have adapted three scenarios existing for Run2 2018 HI Run to create the corresponding Run3 ones, namely:

Once these scenarios are integrated, the plan is to test them with a Tier0 replay on HI 2018 data.

In order to be able to run the Express processing without crashes, we had to introduce a new customization for the offline Tracking DQM, PPonPbPbTrackingOnly_custom.py. @mandrenguyen, please advise and feel free to include any interested parties. We would be specially interested in knowing how will the tracking be handled for the HI and if/how we should adapt the AlCa scenarios introduced here to take it into account.

PR validation:

We have used the tests below for validating each of the workflows. They all run without any crashes.

+=+=+=
trackingOnlyEra_Run3_pp_on_PbPb scenario:
+=+=+=

python3 Configuration/DataProcessing/test/RunRepack.py --lfn file:/eos/cms/store/t0streamer/Data/HIExpressAlignment/000/327/527/run327527_ls0051_streamHIExpressAlignment_StorageManager.dat

python3 Configuration/DataProcessing/test/RunExpressProcessing.py --scenario trackingOnlyEra_Run3_pp_on_PbPb --global-tag 124X_dataRun3_Express_TIER0_REPLAY_Run2_v2 --lfn file:write_PrimDS1_RAW.root --alcarecos=TkAlMinBias+PromptCalibProdBeamSpotHP

python3 Configuration/DataProcessing/test/RunAlcaSkimming.py --scenario trackingOnlyEra_Run3_pp_on_PbPb --lfn file:output.root --global-tag 124X_dataRun3_Express_TIER0_REPLAY_Run2_v2 --skims TkAlMinBias,PromptCalibProdBeamSpotHP

python3 Configuration/DataProcessing/test//RunAlcaHarvesting.py --scenario trackingOnlyEra_Run3_pp_on_PbPb --lfn file:TkAlMinBias.root --dataset /A/B/C --global-tag 124X_dataRun3_Express_TIER0_REPLAY_Run2_v2 --alcapromptdataset=PromptCalibProdBeamSpotHP

+=+=+=
ppEra_Run3_pp_on_PbPb scenario:
+=+=+=

python3 Configuration/DataProcessing/test/RunRepack.py --lfn file:/eos/cms/store/t0streamer/Data/HIExpressAlignment/000/327/527/run327527_ls0051_streamHIExpressAlignment_StorageManager.dat

python3 Configuration/DataProcessing/test/RunPromptReco.py --scenario ppEra_Run3_pp_on_PbPb --reco --aod --dqmio --global-tag 124X_dataRun3_Prompt_TIER0_REPLAY_Run2_v2 --lfn file:write_PrimDS1_RAW.root --alcareco TkAlMinBias+SiStripCalMinBias

+=+=+=
hcalnzsEra_Run3_pp_on_PbPb scenario:
+=+=+=

python3 Configuration/DataProcessing/test/RunRepack.py --lfn file:/eos/cms/store/t0streamer/Data/HIExpressAlignment/000/327/527/run327527_ls0051_streamHIExpressAlignment_StorageManager.dat

python3 Configuration/DataProcessing/test/RunPromptReco.py --scenario hcalnzsEra_Run3_pp_on_PbPb --reco --aod --dqmio --global-tag 124X_dataRun3_Prompt_TIER0_REPLAY_Run2_v2 --lfn file:write_PrimDS1_RAW.root --alcareco HcalCalMinBias

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

If/when it decided to move forward with this, it should be backported to the HI data-taking release, 125X.

@malbouis
Copy link
Contributor Author

assign alca

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39387/32087

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@saumyaphor4252,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @malbouis for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)
  • DQM/TrackingMonitorSource (dqm)

@perrotta, @malbouis, @rappoccio, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @rvenditti, @micsucmed, @fabiocos, @francescobrivio, @davidlange6 can you please review it and eventually sign? Thanks.
@arossi83, @VourMa, @hdelanno, @sroychow, @JanFSchulte, @VinInn, @Martin-Grunewald, @missirol, @fioriNTU, @jandrea, @mtosi, @idebruyn, @mmusich, @threus, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

please test

@tvami
Copy link
Contributor

tvami commented Sep 13, 2022

@malbouis can you please add it to the unit test in the same folder?

@mandrenguyen
Copy link
Contributor

assign reconstruction

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@mandrenguyen,@clacaputo you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39387/32088

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@malbouis
Copy link
Contributor Author

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-667b52/27581/summary.html
COMMIT: 655c73a
CMSSW: CMSSW_12_6_X_2022-09-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39387/27581/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618326
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618296
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@malbouis
Copy link
Contributor Author

tests have passed. If there are no objections I will turn this into a full PR.

@tvami
Copy link
Contributor

tvami commented Sep 16, 2022

+alca

  • unit tests pass, trusting also the private results from @malbouis
  • of course the real test of the pudding is going to be with the T0 replay

@malbouis malbouis marked this pull request as ready for review September 16, 2022 14:24
@emanueleusai
Copy link
Member

+1

@tvami
Copy link
Contributor

tvami commented Sep 17, 2022

urgent

  • the backport of this should be part of 12_5_0, which will be coming out next Tue
  • @mandrenguyen can you please review and sign?

@mandrenguyen
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 7e88734 into cms-sw:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants