-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_4_X] Update PPS DMD tag, remove deprecated SiStrip DMD tag, add SiStripBadStripFromHitEffRcd
#39383
[12_4_X] Update PPS DMD tag, remove deprecated SiStrip DMD tag, add SiStripBadStripFromHitEffRcd
#39383
Conversation
A new Pull Request was created by @francescobrivio for CMSSW_12_4_X. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @ggovi, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e46a17/27502/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #39380
PR description:
As requested in this CMSTalk post, we update the DropBoxMetadata for PPS PCL:
CTPPSRPAlignment_byPCL_v0_prompt
-->CTPPSRPAlignment_byPCL_v1_prompt
CTPPPSTimingCalibration_SAMPIC_byPCL_v0_prompt
-->CTPPPSTimingCalibration_SAMPIC_byPCL_v1_prompt
I also profit of this PR for two further updates of the DMD scripts:
SiStripApvGainRcdAfterAbortGap
key which is deprecated in favor ofSiStripApvGainAAG
as described in Remove SiStripApvGainRcdAfterAbortGap from DMD cms-AlCaDB/AlCaTools#77CondFormats/Common/test/DropBoxMetadataReader.py
Finally, this PR includes a backport of #37997 which added the
SiStripBadStripFromHitEffRcd
key in the DMD (that was never back-propagated to 12_4_X).PR validation:
See master PR
Backport:
Backport of #39380
Backport of #37997