Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supply DQM for SiPixelCalSingleMuonTight #39382

Merged
merged 1 commit into from
Sep 15, 2022
Merged

supply DQM for SiPixelCalSingleMuonTight #39382

merged 1 commit into from
Sep 15, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 13, 2022

PR description:

With the foreseen increase of isolated muon trigger rates (see https://its.cern.ch/jira/browse/CMSHLT-2465 ) it becomes possible to run the SiPixelCalSingleMuonTight at express, allowing for quasi-online efficiency monitoring.
This PR adds a stub of DQM monitor for that AlCa flavour to start producing basic cluster properties histograms that are used as ingredients of the hit efficiency measurement.

PR validation:

Run

 runTheMatrix.py -l 1002.4 -t 4 -j 8 --iboes

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will need to be backported

@mmusich
Copy link
Contributor Author

mmusich commented Sep 13, 2022

type trk, new-feature

@cmsbuild cmsbuild added this to the CMSSW_12_6_X milestone Sep 13, 2022
@mmusich
Copy link
Contributor Author

mmusich commented Sep 13, 2022

test parameters:

  • workflow = 1002.4

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39382/32085

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • DQMOffline/CalibTracker (dqm)
  • DQMOffline/Configuration (dqm)

@perrotta, @rappoccio, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @davidlange6, @micsucmed, @fabiocos, @rvenditti can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @mmusich, @threus, @dgulhan, @slomeo, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 13, 2022

@cmsbuild, please test

This was referenced Sep 13, 2022
Merged
Merged
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b00a7f/27500/summary.html
COMMIT: bafba68
CMSSW: CMSSW_12_6_X_2022-09-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39382/27500/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b00a7f/1002.4_RunDoubleMuon2022B+RunDoubleMuon2022B+TIER0PROMPTRUN3+HARVESTPROMPTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3720269
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3720243
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.926 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 2.455 KiB AlCaReco/SiPixelCalSingleMuonTight
  • DQMHistoSizes: changed ( 1000.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0,... ): 0.004 KiB MessageLogger/Warnings
  • Checked 215 log files, 49 edm output root files, 52 DQM output files
  • TriggerResults: found differences in 2 / 51 workflows

@emanueleusai
Copy link
Member

+1

@mmusich mmusich force-pushed the SiPixelCalSingleMuonTightDQM branch from bafba68 to dbb71e4 Compare September 15, 2022 07:37
@mmusich
Copy link
Contributor Author

mmusich commented Sep 15, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b00a7f/27553/summary.html
COMMIT: dbb71e4
CMSSW: CMSSW_12_6_X_2022-09-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39382/27553/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b00a7f/1002.4_RunDoubleMuon2022B+RunDoubleMuon2022B+TIER0PROMPTRUN3+HARVESTPROMPTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3720269
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3720234
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.926 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 2.455 KiB AlCaReco/SiPixelCalSingleMuonTight
  • DQMHistoSizes: changed ( 1000.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0,... ): 0.004 KiB MessageLogger/Warnings
  • Checked 215 log files, 49 edm output root files, 52 DQM output files
  • TriggerResults: found differences in 2 / 51 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Sep 15, 2022

found errors in the following unit tests:
---> test test-das-selected-lumis had ERRORS

test failure is unrelated.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 15, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b00a7f/27567/summary.html
COMMIT: dbb71e4
CMSSW: CMSSW_12_6_X_2022-09-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39382/27567/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b00a7f/1002.4_RunDoubleMuon2022B+RunDoubleMuon2022B+TIER0PROMPTRUN3+HARVESTPROMPTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3720269
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3720237
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.926 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 2.455 KiB AlCaReco/SiPixelCalSingleMuonTight
  • DQMHistoSizes: changed ( 1000.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0,... ): 0.004 KiB MessageLogger/Warnings
  • Checked 215 log files, 49 edm output root files, 52 DQM output files
  • TriggerResults: found differences in 2 / 51 workflows

@perrotta
Copy link
Contributor

@emanueleusai , the changes since your previous signature are rather minor, and do not affect the results, I keep that signature for good and merge this PR in the master, aiming at merging its backports by tomorrow.

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 017a0b9 into cms-sw:master Sep 15, 2022
@mmusich mmusich deleted the SiPixelCalSingleMuonTightDQM branch September 16, 2022 07:18
@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@francescobrivio francescobrivio mentioned this pull request Sep 19, 2022
Closed
@makortel makortel mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
code-checks-approved dqm-approved fully-signed new-feature operations-approved orp-approved tests-approved trk
Projects
None yet
Milestone
CMSSW_12_6_X
Development

Successfully merging this pull request may close these issues.
4 participants
@mmusich @cmsbuild @emanueleusai @perrotta