Fixed RP IDs in the PPS alignment harvester

[grzanka]

PR description:

Currently, the alignment harvester saves an SQLite file with short RP IDs (3, 23, 103, 123). Other reproduction modules (CTPPSGeometryESModule) expect long 32-bit IDs. This pull request fixes this issue by updating PPSAlignmentHarvester.

PR validation:

• Reproduce the results in CalibPPS/AlignmentGlobal/test.
• Run the whole reconstruction which now can retrieve the data from the alignment SQLite file.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39358/32061

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @grzanka (Leszek Grzanka) for master.

It involves the following packages:

• CalibPPS/AlignmentGlobal (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@fabferro, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

type bug-fix

[francescobrivio]

@grzanka I believe this is intended for data taking, thus should be backported to 12_5_X and 12_4_X?

[francescobrivio]

type ctpps

[MatiXOfficial]

@grzanka I believe this is intended for data taking, thus should be backported to 12_5_X and 12_4_X?

Yes, backports will be submitted soon.

[francescobrivio]

test parameters:

• workflows = 1043

[francescobrivio]

test parameters:
*

[francescobrivio]

test parameters:

• workflow = 1045

[francescobrivio]

@cmsbuild please test

[tvami]

@cmsbuild , please abort

[tvami]

test parameters:

• workflows = 1042,1045

[tvami]

@cmsbuild , please test

• now making sure that it will work for Run-2 too

[tvami]

urgent

• backport should go into the next 12_4_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb0406/27450/summary.html
COMMIT: cc299e3
CMSSW: CMSSW_12_6_X_2022-09-09-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39358/27450/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-eb0406/1042.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCALALIG+ALCASPLITPPSALIG+ALCAHARVDPPSALIG
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-eb0406/1045.0_RunRawPPS2022B+RunRawPPS2022B+TIER0EXPPPSCALRUN3+ALCASPLITPPSALIGRUN3+ALCAHARVDPPSALIGRUN3

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 3619010
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3618980
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 220 log files, 49 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[ChrisMisan]

+alca

• tests pass
• harvester is producing results

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1