[12.4.X] SiStripHitEfficiency PCL workflow, take into account modules with FEDErrors

[mmusich]

backport of #39351

PR description:

When using the DQM files produced by the SiStripHitEfficiency PCL in 2022 data, it was noticed that not all the modules that should be masked with the SiStripQuality are effectively masked within the DQM workflow, when comparing with the traditional calibrations-tree based workflow.
The issue has been traced down on the usage of the modules affected by FEDErrors in the computation of the efficiency.
In PR #38592 a mechanism to count the FEDErrors per module (via commit 44999ca ) was introduced since at the harvesting step level it's not possible to access directly at the per-event FEDErrors edm collection. This entailed populating a TkHistoMap with the occupancy of modules in FEDError per event, but this approach had two problems:

• the filling of the map occurred in the endJob transition of StripHitEfficiencyWorker (that in a DQMEDAnalyzer is not run by the framework, resulting in empty maps cf https://tinyurl.com/2p5tdgqs)
• secondly the information was never propagated to the SiStripHitEfficiencyHarvester such that those modules could be excluded from the list of inefficient ones.

This PR solves the issue by changing the SiStripHitEffData ancillary struct and its usage in the classes of the SiStripHitEfficiency PCL workflow. A somewhat arbitrary threshold of 75% of the events is used to flag modules that have problems with FEDErrors, permanently excluding them from the computation.

Finally I profit of this to transform a relic thread-unsafe cout to the message logging system in commit dee0359.

PR validation:

Run the following commands:

cmsDriver.py stepReAlCa -s ALCA:PromptCalibProdSiStripHitEff --conditions 124X_dataRun3_Express_v5 --scenario pp --data --era Run3 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100000 --dasquery='file dataset=/StreamExpress/Run2022D-SiStripCalMinBias-Express-v2/ALCARECO run=357898' --nThreads=4

followed by:

cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripHitEff --conditions 124X_dataRun3_Express_v5 --scenario pp --data --era Run3 --filein file:PromptCalibProdSiStripHitEff.root -n -1

with this branch and without it and observed the following features:

• the FEDErrorTkDetMaps folder now contains full plots (as can be checked at https://tinyurl.com/2z7nrg9a after logging with ssh -NL 8060:localhost:8060 <USER>@lxplus724.cern.ch)
• some regions in TEC that were contributing to the inefficiency (because in FED Error) are now correctly excluded:

Name	Pre-fix	Post-fix
Efficiency Map
Inefficient Modules

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #39351 to CMSSW_12_5_X (for data-taking purposes)

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from SiStripHitEfficiency PCL workflow, take into account modules with FEDErrors #39351

[mmusich]

type bug-fix

[mmusich]

test parameters:

• workflows = 1001.2, 1001.3

[mmusich]

@cmsbuild, please test

[francescobrivio]

urgent

• targeting next 12_4_X release (with the caveat that more commits from @mmusich might be added in the next days in case the master version needs more updates)

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c10b19/27447/summary.html
COMMIT: dee0359
CMSSW: CMSSW_12_4_X_2022-09-09-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39357/27447/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 1331.01331.0_ZTT_13+ZTT_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15/step2_ZTT_13+ZTT_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15+NANOUP15.log

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c10b19/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c10b19/1001.3_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3692331
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3692290
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 51 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 219 log files, 45 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c10b19/27458/summary.html
COMMIT: dee0359
CMSSW: CMSSW_12_4_X_2022-09-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39357/27458/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c10b19/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c10b19/1001.3_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3692331
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3692290
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 51 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 219 log files, 45 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1