Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.5.X] PrimaryVertexMonitor: fix beamspot centering for Run3 and actually fill the beamspot type histograms #39333

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 7, 2022

backport of #39322

PR description:

When casually looking at the GUI, I noticed that:

  • X0 and Y0 coordinate plots are empty (because the position of the Run-3 Beam Spot exceeds the current range.
  • the Beam Spot type plot is also empty (because not filled)

PR validation:

None, but changes are trivial

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

vertbatim backport of #39322 to 12.5.X

@mmusich
Copy link
Contributor Author

mmusich commented Sep 7, 2022

type bug-fix

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Sep 7, 2022
@mmusich
Copy link
Contributor Author

mmusich commented Sep 7, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_5_X.

It involves the following packages:

  • DQMOffline/RecoB (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @AnnikaStein, @JyothsnaKomaragiri, @andrzejnovak, @demuller, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49c005/27400/summary.html
COMMIT: d10ec31
CMSSW: CMSSW_12_5_X_2022-09-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39333/27400/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 81
  • DQMHistoTests: Total nulls: 97
  • DQMHistoTests: Total successes: 3695508
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • differences in DQM plots in HLT/Vertexing and OfflinePV/offlineBeamSpot as expected

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 8, 2022

+1

@cmsbuild cmsbuild merged commit 396f984 into cms-sw:CMSSW_12_5_X Sep 8, 2022
@mmusich mmusich deleted the fixPrimaryVertexMonitor_12_5_X branch September 8, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants