-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for PNET DQM monitoring #39272
Fix for PNET DQM monitoring #39272
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39272/31921
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
…/rgerosa/cmssw into particle_net_monitoring_dqm_126X
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39272/31924
|
A new Pull Request was created by @rgerosa (raffaele gerosa) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
type bugfix |
-1 Failed Tests: RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
Failures detected should not be related to this PR |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eda95c/27265/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@rgerosa this should now get backported tp 12_5_X, as you anticipate in the PR description |
Following the discussion with @perrotta in PR39146, this PR includes a couple of fixes for the PNET triggers monitor in DQM:
Once approved: (1) back-port to 12-5-X will be open, (2) the PR mentioned above will be merged in 12-4-X