[GSF tracking] Add TSOS only if it is meaningful

[swagata87]

PR description:

It's an attempt to address github issue #39234

There is a long-standing problem that Gsf track reconstruction in HLT (to a lesser extent also offline) generates a bit too many warning and error messages. The issue has been there since a while. Recently DAQ has also pointed it out: https://its.cern.ch/jira/browse/CMSHLT-2449 . This is a try to reduce the warnings/errors without compromising with performance. (FYI @missirol )

PR validation:

HLT

Ran HLT on 200 raw events and checked HLT decisions before and after the PR.

Running on /store/data/Run2022C/EGamma/RAW/v1/000/355/872/00000/3b478527-d206-4b8e-8004-08e9aff7758b.root (EGamma dataset, 2022C).

HLT name                 | Passed (after PR) | Passed (Base) 

HLT_Ele32_WPTight_Gsf_v16                 | 33 |   33
HLT_Ele135_CaloIdVT_GsfTrkIdT_v8          | 0  |   0  
HLT_Ele50_CaloIdVT_GsfTrkIdT_PFJet165_v19 | 1  |   1 
HLT_Ele28_eta2p1_WPTight_Gsf_HT150_v14    | 5  |   5 

Running on /eos/cms/store/group/dpg_trigger/comm_trigger/TriggerStudiesGroup/STORM/RAW/Run2022B_HLTPhysics0_run355558/cd851cf4-0fca-4d76-b80e-1d33e1371929.root (HLTPhysics, 2022B),

HLT name                 | Passed (after PR) | Passed (Base) 

HLT_Ele32_WPTight_Gsf_v16                 | 0 | 0
HLT_Ele135_CaloIdVT_GsfTrkIdT_v8          | 0 | 0    
HLT_Ele50_CaloIdVT_GsfTrkIdT_PFJet165_v19 | 0 | 0   
HLT_Ele28_eta2p1_WPTight_Gsf_HT150_v14    | 0 | 0    

HLT decision of paths running Gsf tracking remain same before and after this PR.

In the HLTPhysics file, warning/error messages from Gsf reconstruction before and after this PR are:
Before: cat hlt_before_hltphysics.log | grep 'GsfTrackProducer:' | wc -l 540
After: cat hlt_after_hltphysics.log | grep 'GsfTrackProducer:' | wc -l 8

Offline

Ran Reco step on 200 events from /store/relval/CMSSW_12_4_0/RelValTTbarToDilepton_14TeV/GEN-SIM-DIGI-RAW/124X_mcRun3_2022_realistic_v5-v1/2580000/0181721e-24a2-44dd-b514-8f53014ac9a0.root; before and after this PR. Compared track related quantities of reconstructed electrons. No difference found.

runTheMatrix.py -l 11834.0 worked fine.

This PR is not a backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39256/31901

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

• TrackingTools/GsfTracking (reconstruction)

@jpata, @cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @bellan, @ebrondol, @lecriste, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

please test

[fwyzard]

Running over 10k events, this does reduce significantly the amount of warnings:

-     16 %MSG-e PosteriorWeightsCalculator:   GsfTrackProducer:hltEgammaGsfTracksForBParking
-     33 %MSG-e PosteriorWeightsCalculator:  GsfTrackProducer:hltEgammaGsfTracks
-   2232 %MSG-w BasicTrajectoryState:  GsfTrackProducer:hltEgammaGsfTracks
-    186 %MSG-w BasicTrajectoryState:  GsfTrackProducer:hltEgammaGsfTracksForBParking

with only a small increase in the number of errors:

-     33 %MSG-e GsfMultiStateUpdator:  GsfTrackProducer:hltEgammaGsfTracks
+     40 %MSG-e GsfMultiStateUpdator:  GsfTrackProducer:hltEgammaGsfTracks

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe95af/27209/summary.html
COMMIT: f3afc63
CMSSW: CMSSW_12_6_X_2022-08-30-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39256/27209/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3620448
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3620409
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
no change observed to reco.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[fwyzard]

@swagata87 could you make backports for 12.4.x and 12.5.x ?
Thanks !

[swagata87]

type egamma

[rappoccio]

+1

[Sam-Harper]

thank you Swagata!